| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 23:52:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=245.93453,conversation_content-fragment;desc="conversation_content fragment";dur=596.577474,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=267.181421,nginx;desc="NGINX";dur=0.987273,glb;desc="GLB";dur=101.322379
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pVFyfxgLS4Nn2F2ni05UsobQ1xxj9q0Fy%2BH5D5%2BV3q9vLLPym6ECOTf1iIFYkTViX9ehyR8StCkpH4ySZQVzka2t0SE5ajdxjMxkwW4J5gHLH9ifOkQmqEEpH7rr4nVfGPrqwOtTdpkD%2BKD9HsxWBATfvNorF4QEYWvTuyV3i5ZoTQ5SA5vyvF%2FBT7iqKSE4q5b09czV2mLLGSCtIyb1OtMc9YV4ZAn3KyP%2BHtGfz7%2BB3z%2Bytai0JgDyL%2FT7wvguWPoOmycA9ay7T9%2Fm9t7n1Q%3D%3D--4X0ch4GpTC8nInGb--JYPi97UnVs%2BS08uQS%2BK0Wg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1061783655.1753487542; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 23:52:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 23:52:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C2A2:3240E6:38E09:5ABA1:688418B6
[CodeStyle][Ruff] Introduce rule `B005` and fix discovered bugs by gouzil · Pull Request #72896 · PaddlePaddle/Paddle · GitHub
[CodeStyle][Ruff] Introduce rule
SigureMo
changed the title
[CodeStyle][Ruff] add
[CodeStyle][Ruff] Introduce rule May 23, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CodeStyle][Ruff] Introduce rule B005 and fix discovered bugs
#72896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
May 22, 2025
| @@ -97,9 +97,11 @@ def prune_fp16(block, shard, reduced_grads_to_param, ring_ids): | |||
| output_name = op.desc.output_arg_names()[0] | |||
| # TODO (JZ-LIANG) revise this for uniform mixed parallelism | |||
| param_name = ( | |||
| output_name.strip("@GRAD@MERGED") | |||
| output_name.removeprefix("@GRAD@MERGED").removesuffix( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 removesuffix 就好，因为老 IR 里这些一定是后缀，或者说这里可以改成
param_name = output_name.removesuffix("@MERGED").removesuffix("@GRAD")这样就好了，也不用加什么 if
SigureMo
changed the title
B005 ruleB005 and fix discovered bugs
|
skip-reason: codestyle only |
SigureMo
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
User Experience
PR Types
Not User Facing
Description
B005规则，用于明确删除前缀后缀字符串缀意图Link:
.strip()with multi-character strings is misleading the reader #52103