| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:54:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=377.594706,conversation_content-fragment;desc="conversation_content fragment";dur=1195.378978,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=370.383538,nginx;desc="NGINX";dur=1.314217,glb;desc="GLB";dur=102.116108
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=0Lr8g9Dtmsnytr22RI%2BAN9NwGpDbEawgogvMPEjRndFpYa%2Fia6XiVg9Rmubpr%2BPuBt8b459OqVTV1cj%2Fg1moei%2FVQ0n1UalsLQ9jb5n%2B1N611oj%2F%2BHhdYfefmyZ4m6R21vx7c3p3m%2Bib8CuKf%2B6hS4CHZjvGCalfHzKqqK7Yr2213mYsUy4oMmqQIIMe29p8XdP8PQHhH8%2BXdlp%2BMkKTW%2FcQGBsWkMoQI5NOJS912XWy8lyazwviJkTYCIDKWpficrspp653CRRdd4gEqBEOgQ%3D%3D--VjzK9b5xyEmeB6IZ--Ig0gROnxqu5qAeNjPNH9hg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1682549068.1753268072; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:54:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:54:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8794:20AC8F:9BA901:BBBF0D:6880BF68
[CodeStyle][3.8] Replace `{**A, **B}` with `A | B` (PEP 584) by gouzil · Pull Request #72891 · PaddlePaddle/Paddle · GitHub
[CodeStyle][3.8] Replace
[CodeStyle][3.8] Replace
SigureMo
changed the title
[CodeStyle][3.8] use
[CodeStyle][3.8] Replace May 22, 2025
SigureMo
changed the title
[CodeStyle][3.8] Replace
[CodeStyle][3.8] Replace May 22, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CodeStyle][3.8] Replace {**A, **B} with A | B (PEP 584)
#72891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
gouzil:py38/better_dict_union_method
May 23, 2025
Merged
[CodeStyle][3.8] Replace {**A, **B} with A | B (PEP 584)
#72891
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
gouzil:py38/better_dict_union_method
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
May 22, 2025
python/paddle/jit/utils.py
Outdated
| **{item: None for item in self if item not in other}, | ||
| **{item: None for item in other if item not in self}, | ||
| self._data = {item: None for item in self if item not in other} | { | ||
| item: None for item in other if item not in self | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上面的注释瞅一眼啊，直接删掉注释
test/sot/test_10_build_unpack.py
Outdated
| @@ -57,7 +57,7 @@ def build_tuple_unpack_with_call_inner( | |||
|
|
|||
|
|
|||
| def build_map_unpack(x: dict[str, paddle.Tensor], y: dict[str, paddle.Tensor]): | |||
| z = {**x, **y} | |||
| z = x | y | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不能改啊，不过后面给 dict 支持下 operator.or_ 来支持这种 case
test/sot/test_functools.py
Outdated
| @@ -74,7 +74,7 @@ def test_reduce_list(self): | |||
| def test_reduce_dict(self): | |||
| d1 = {"a": 1, "b": 2} | |||
| d2 = {"a": 3, "c": 4} | |||
| self.assert_results(try_reduce, lambda a, b: {**a, **b}, [d1, d2]) | |||
| self.assert_results(try_reduce, lambda a, b: a | b, [d1, d2]) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以改，因为在转静代码外
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
啊，这里也不能改，这是个函数，在 try_reduce 里才执行
SigureMo
changed the title
$A|$B replace {**$A, **$B}{**A, **B} with A | B
SigureMo
changed the title
{**A, **B} with A | B{**A, **B} with A | B (PEP 584)
SigureMo
reviewed
May 22, 2025
SigureMo
previously approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dictionary merging to use the PEP 584 union operator (A | B) instead of the older unpack syntax ({**A, **B}), aligning with the removal of Python 3.8 support.
- Replace
{**A, **B}patterns withA | Bacross tools, tests, and core library code - Remove obsolete comments and conditional unpack workarounds for older Python versions
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/sampcd_processor.py | Use ` |
| test/prim/model/test_comp_model_simple_net.py | Update feed dict construction to ` |
| test/legacy_test/prim_op_test.py | Replace unpacked dicts with union in no_grad_vars |
| test/legacy_test/auto_parallel_op_test.py | Use `inputs_dict |
| test/deprecated/prim/prim/vjp/static/test_comp_multiply_grad_deprecated.py | Apply union operator in feed dict for deprecated test |
| test/deprecated/legacy_test/auto_parallel_op_test.py | Update no_grad_vars dict merge to ` |
| python/paddle/jit/utils.py | Remove TODO and switch _data assignment to ` |
| python/paddle/jit/sot/opcode_translator/executor/variables/base.py | Change info dict merge to ` |
| python/paddle/distributed/fleet/meta_parallel/parallel_layers/pp_layers.py | Use `self.kwargs |
| python/paddle/cinn/runtime/utils.py | Merge function scope dicts using ` |
| paddle/fluid/primitive/codegen/decomp_vjp_gen.py | Convert list-comprehension dict merges to ` |
| paddle/fluid/primitive/codegen/decomp_rule_gen.py | Use `api |
| paddle/fluid/pir/dialect/op_generator/api_gen.py | Simplify mapping_name_to_type merge to ` |
Comments suppressed due to low confidence (1)
tools/sampcd_processor.py:380
- The dictionary union operator (
|) requires Python >= 3.9. Ensure that the project’s minimum Python version is updated accordingly in the CI and documentation.
self.config = XDOCTEST_CONFIG | (config or {})
SigureMo
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Deprecations
Description
在 python3.8 以上版本，使用 dict union 替代
{**$A, **$B}写法。python 3.8 已经退场Link: https://peps.python.org/pep-0584/