| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 21:52:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=249.59342,conversation_content-fragment;desc="conversation_content fragment";dur=854.527646,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=285.96123,nginx;desc="NGINX";dur=0.742707,glb;desc="GLB";dur=101.228649
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=r5R1zpZHadV5FLaLDBDQBwhsLsKsGxd%2FRZ2cm0pzEyZNTmC%2FMOn5ZAU85sQwbyIg0UTzoqguZvlm7prlFkuUw2dTWStL9FYz%2Fkg3gCX9m54FaU0nsE6YvB7jgETUnTiUd1ehjbWXWrcF51%2BILj1uq23weDTiLtDCMigZ4pyus66rbJtAYJfQ1MIQ%2B2lNpJEtzcUQ%2B6U3qfiJlyBTT7J0PegvlBNR678KJm9SFN9jvcZJAKZrALcU1%2FPTSVxXkeT3l5H3Lj806gs0DEHATkp2Uw%3D%3D--LY%2Br7UpiEIRU1i92--%2FETFfx%2Baha%2Bz9zWsZiF28Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1059951879.1753393957; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 21:52:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 21:52:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A4A0:25E19F:AD17D:F19EA:6882AB25
[SOT][3.8] Cleanup `eval_frame` python3.9- code by gouzil · Pull Request #72868 · PaddlePaddle/Paddle · GitHub
[SOT][3.8] Cleanup
gouzil
requested review from
Copilot
and removed request for
SigureMo and
zrr1999
May 22, 2025 04:26
SigureMo
changed the title
[3.8] clean
[3.8] Cleanup May 22, 2025
SigureMo
changed the title
[3.8] Cleanup
[SOT][3.8] Cleanup May 22, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][3.8] Cleanup eval_frame python3.9- code
#72868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
requested review from
Copilot
and removed request for
SigureMo and
zrr1999
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up legacy Python eval_frame code by removing support for Python versions older than 3.9. It deprecates outdated conditions and macros while simplifying eval_frame callback logic.
- Update the test to require Python 3.9–3.13
- Remove Python 3.8-specific macros and fallback code
- Simplify version-specific branches in eval_frame implementation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/dygraph_to_static/test_eval_frame.py | Update test condition and comment to reflect new Python version support |
| paddle/fluid/pybind/sot/macros.h | Remove obsolete Python 3.8 definitions and macros |
| paddle/fluid/pybind/sot/guards.cc | Remove fallback implementation for PyObject_CallOneArg for Python below 3.9 |
| paddle/fluid/pybind/sot/eval_frame.c | Eliminate legacy conditional branches for Python versions earlier than 3.9 |
Comments suppressed due to low confidence (2)
paddle/fluid/pybind/sot/eval_frame.c:63
- Add a comment noting that the alternative branch for Python versions below 3.9 has been removed to simplify the eval_frame logic.
return _PyEval_EvalFrameDefault(tstate, frame, throw_flag);
paddle/fluid/pybind/sot/guards.cc:23
- Confirm that the removal of the fallback for PyObject_CallOneArg is intentional and documented elsewhere, given the deprecation of pre-Python 3.9 support.
#if !defined(PyObject_CallOneArg) && !PY_3_9_PLUS
| @@ -28,8 +28,8 @@ def tearDown(self): | |||
| pass | |||
|
|
|||
| def test_eval_frame(self): | |||
| if not (sys.version_info >= (3, 8) and sys.version_info < (3, 14)): | |||
| # skip test_eval_frame, current only support 3.8 - 3.13 | |||
| if not (sys.version_info >= (3, 9) and sys.version_info < (3, 14)): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider updating the inline comment to clearly state that only Python 3.9 to 3.13 are supported. A revision for clarity (eg. 'supported: Python 3.9 to 3.13') could benefit future readers.
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个还是有点用的啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不对啊，明明改了啊，为啥还会 comment
SigureMo
reviewed
May 22, 2025
paddle/fluid/pybind/sot/eval_frame.c
Outdated
| @@ -376,18 +367,11 @@ static PyObject *_custom_eval_frame_shim(PyThreadState *tstate, | |||
| return _custom_eval_frame(tstate, frame, throw_flag, callback); | |||
| } | |||
|
|
|||
| #if PY_3_9_PLUS | |||
| static PyObject *custom_eval_frame_shim(PyThreadState *tstate, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个函数是不是可以删掉了？再把 _custom_eval_frame_shim rename 成 custom_eval_frame_shim
SigureMo
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
SigureMo
changed the title
eval_frame python3.9- codeeval_frame python3.9- code
SigureMo
changed the title
eval_frame python3.9- codeeval_frame python3.9- code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Deprecations
Description
eval_framepython3.9- 相关代码