You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates setup scripts to remove Python 3.8 support and require Python >= 3.9.
Bumped version checks from 3.8 to 3.9 and updated associated error messages.
Adjusted dependency-filter logic to skip constraints targeting Python < 3.9.
Removed “Programming Language :: Python :: 3.8” classifiers.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File
Description
setup.py
Version gating, error messages, dependency filters, and classifiers updated
python/setup.py.in
Mirrored version checks, filter logic adjustments, and classifier removal
Comments suppressed due to low confidence (4)
setup.py:50
[nitpick] The error message concatenates without a space, resulting in 'now,you'. Consider changing to "... now, you are using Python {python_version}" for clarity.
f"you are using Python {python_version}"
setup.py:1066
[nitpick] Grammar and formatting: capitalize the sentence, add a space after the comma, and use 'supports' and plural 'versions'. E.g., "Please check your Python version; Paddle only supports Python versions >= 3.9."
"please check your python version, Paddle only support Python version>=3.9 now"
python/setup.py.in:937
[nitpick] Grammar: change 'support' to 'supports', add space before '>=', and consider capitalizing: "Paddle only supports Python versions >= 3.9."
raise RuntimeError("Paddle only support Python version>=3.9 now")
setup.py:46
Consider adding a unit or integration test to verify that running setup with Python < 3.9 raises the expected RuntimeError, ensuring this gating logic remains effective.
SigureMo
changed the title
[3.8] Remove Python 3.8 support speification in setup.py
[3.8] Remove Python 3.8 support speification in setup.pyMay 22, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Deprecations
Description
清理 Python 3.8 支持声明,#72827 已经不再支持 Python 3.8 了,
setup.py
应当同步清理