| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:47:49 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=325.648707,conversation_content-fragment;desc="conversation_content fragment";dur=2020.039615,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=361.438321,nginx;desc="NGINX";dur=1.439278,glb;desc="GLB";dur=101.672251
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YMqxXNQbRWD5K2TeBjsn%2FZMlogI9Eh5ZyBV0sXt8nH7vtACN6YToe3zLI3mZyRgDmuOl3wB7lTLrY%2BgeApKs%2FQ6Zz44IEndSWRXNF9DbvWNTczDV3mZD%2F0I8jJc9jrQj8Z85cTj66kgSwJEg7ou5eUNNqgjvnMJoKwJDQHVUIw%2F2qeq329N4UnQ%2BNcO%2F3eYpimwJDRRAHd8cEGlI9nn79Lbod0suFHddAyrFMOUsKRuWuDBDgVP4iYGzduG3aIVSdBPlkBtIrfsVGKvGHzHYPA%3D%3D--8A0MxLEab482M2s1--%2BYR5X7QheLkixIW0GP58ZQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.583290279.1753332467; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:47:47 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:47:47 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B81C:0A93:28D946:393240:6881BAF3
[SOT][PIR] Mark `item` to breakgraph && add unittest of tensor array related APIs by DrRyanHuang · Pull Request #72631 · PaddlePaddle/Paddle · GitHub
[SOT][PIR] Mark
SigureMo
changed the title
[SOT] Mark
[SOT] Mark May 10, 2025
SigureMo
changed the title
[SOT] Mark
[SOT][PIR] Mark May 13, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][PIR] Mark item to breakgraph && add unittest of tensor array related APIs
#72631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: 为什么不把 create_array、array_write、array_read、array_length 放到 SIR？
实际上，这些 API 严格上不是「动静统一」的，它们在纯动态图、纯静态图/AST 动转静模式下确实是逻辑自洽的，纯动态图操作的都是 list[Tensor]，纯静态图则都是 TensorArray，但在动静混合的情况下就不是这样了。
首先，SOT 随时可能发生打断，其中任何一个 API 都可能在动态图/静态图跑，一种简单的 case，一旦 create_array 在动态图跑，而 array_write 在静态图跑，那就会因为前者创建了 list[Tensor]，导致后者预期类型不匹配，本应是 TensorArray，但却不是，就会挂掉，反之亦然
其实即便 create_array 和 array_write 都在静态图跑也会有问题，一旦中间发生了打断，那么 create_array 的结果必然会作为前一个子图的输出，而动态图下是没有 TensorArray 的，也就是说 TensorArray 并不能作为子图输出，从这一点上来看，这些 API 在 SOT 下是绝对不可以跑静态图分支的，因此目前决定这些 API 仍然跑动态图分支（通过模拟的方式）
TODO:
- 我们模拟的时候是否可以感知到
TensorArray的存在，一旦发现TensorArray，就在子图边界将其转换为list[Tensor]？
SigureMo
reviewed
May 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #72631 +/- ##
==========================================
Coverage ? 96.55%
==========================================
Files ? 1
Lines ? 29
Branches ? 0
==========================================
Hits ? 28
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SigureMo
changed the title
item to breakgraph && add unitest of array* apiitem to breakgraph && add unittest of tensor array related APIs
SigureMo
reviewed
May 12, 2025
DrRyanHuang
commented
May 12, 2025
SigureMo
reviewed
May 12, 2025
SigureMo
changed the title
item to breakgraph && add unittest of tensor array related APIsitem to breakgraph && add unittest of tensor array related APIs
SigureMo
previously approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
| @@ -124,6 +124,7 @@ def _get_tensor_methods(): | |||
| 'numpy', | |||
| 'clear_gradient', | |||
| 'tolist', | |||
| 'item', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO：后续可以探索非打断的，输出是 SymbolicVariable 的实现
SigureMo
reviewed
May 14, 2025
这些分支是没测过吗？ |
SigureMo
previously approved these changes
May 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
DrRyanHuang
commented
May 15, 2025
Comment on lines
+296
to
+297
| # NOTE: This is to maintain consistency with the original code. | ||
| return self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: 这部分提前 return 主要是与之前保持一致
如果不加这个 early return 会导致 test_asgd_op PIR + 混合精度模式下返回 NaN
"Test pir graph mode"
output1_pir = self.pir_asgd_mp(mp=True) # <--- 第一个结果正确，后续4个结果都为 NaN
output2_pir = self.pir_asgd_mp(mp=False)
for idx in range(5):
np.testing.assert_allclose(
output1_pir[idx].astype('float32'),
output2_pir[idx].astype('float32'),
rtol=1e-05,
atol=0.1,
)
SigureMo
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
PCard-66972