| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:54:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=388.99999,conversation_content-fragment;desc="conversation_content fragment";dur=789.591813,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=454.531836,nginx;desc="NGINX";dur=0.587397,glb;desc="GLB";dur=99.97133
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CG1rlFV9cLPxuMmI46AwYVWWSL7U5b1q%2FdtPnxDxhmmwRoGs6NMeod3ui5JOkK0TEQhv7Yp%2B2pcw94Huu%2Bux8ozDYXQsq2eZ0sFFkK%2FAzevO2hN1drES8gDwF%2FqJgwROQH%2BTkcNjv661j4RJsLHfr7jttox4f6GUQIwtTABZtSfzRDseyEs9Gzk4DsLiOXgpiNu9oIvPbXXyxRsbc33N50QlvGE4Y1W9dGmjmSDEWZvIeubBgCQW7CAIoQfovcC%2FYHPhDC32go2u3zbCxVQdbA%3D%3D--qOrKXUwNYwLlFMLR--EYCc1IYz%2B9YROwogQNYqvQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.672251387.1753268045; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:54:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:54:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BFC0:39062F:9B96B4:BBA952:6880BF4D
[Infra][Dy2St] Remove manual unparse logic for Python 3.8 in check approval script by SigureMo · Pull Request #72560 · PaddlePaddle/Paddle · GitHub
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
April 30, 2025 03:20
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Infra][Dy2St] Remove manual unparse logic for Python 3.8 in check approval script #72560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:dy2st/remove-manual-unparse-logic-for-py38
Apr 30, 2025
Merged
[Infra][Dy2St] Remove manual unparse logic for Python 3.8 in check approval script #72560
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:dy2st/remove-manual-unparse-logic-for-py38
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the manual AST unparse logic for Python 3.8 from the check approval script and now relies exclusively on ast.unparse available in Python 3.9 and later.
- Removed the branch handling manual unparse for various AST node types
- Updated the conditional to throw an error when running on Python versions before 3.9
Comments suppressed due to low confidence (1)
test/dygraph_to_static/check_approval.py:55
- [nitpick] Consider adding a comment clarifying that this function now exclusively supports Python 3.9 and later via ast.unparse.
def ast_to_source_code(node: ast.AST):
gouzil
approved these changes
Apr 30, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Devs
Description
清理掉
test/dygraph_to_static/check_approval.py中的 Python 3.8 手写 unparse 逻辑，迁移到 GitHub Actions 后不会再遇到随机到 Python 3.8 的问题（#61540）Related links