CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:53:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=368.877615,conversation_content-fragment;desc="conversation_content fragment";dur=645.420716,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=379.371848,nginx;desc="NGINX";dur=0.702568,glb;desc="GLB";dur=101.978588
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=SiDNLk4oKNilyfyouUX0g48GIguuq1%2BE69AgKiGkX0FGMUc8Y%2FUcVKdq2ehxc25%2B1%2B4CDJbU5%2FIWezSN4eo8Eb3CL2FuaawEpnQxZrFSW4JBWidm9SFu27pEwCxpC109hIbWac2Y9JkGkEUq2ptvKtXd74JAJCMoat8E%2BBZfAF7d%2FZPNK00tRRXlNTxF3I2XmqWHqrWZEo%2F4ykDKpqwrqyKaLa0EqCOGarLFSV9WRe6K2of30QZxwZTRfVvZAhZ9GtYk6SpIuG5m8Xui%2FFL2eg%3D%3D--GC5QQcwJSlKV6GVe--goRkS2vv2yoGlPIc2VlomQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1791411017.1753267986; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:53:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:53:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D82E:256CA9:9AFCFF:BB04AE:6880BF12
[PHI][CINN] Implement int64_t version of FastDivMod by lshpku · Pull Request #72530 · PaddlePaddle/Paddle · GitHub
lshpku
force-pushed
the
fast-divmod-int64
branch
from
April 28, 2025 05:45
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PHI][CINN] Implement int64_t version of FastDivMod #72530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
e4aeef6
to
bbbe8a4
Compare
wanghuancoder
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zyfncg
approved these changes
Apr 28, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
Improvements
Description
实现int64_t版本的FastDivMod,修复大tensor Reduce的部分问题
核心修改:
phi/kernels/funcs/fast_divmod.h
模仿int版本实现了FastDivMod<int64_t>类注:实际上IndexType计算时使用的是uint32_t和uint64_t,但是为了和PHI原有的用法兼容,这里还是用int和int64_t作为模板参数
其他使用了FastDivMod的文件修改:
说明:
index_calculator.h
升级为FastDivMod<IndexType>,这是本PR主要修复的问题stack_and_unstack.h
本来已经用了GeneralDivMod<IndexT>,所以在本PR里直接替换成FastDivMod<IndexT>,GeneralDivMod是之前不支持int64_t所以用来fallback成普通除法的包装类,现在原生支持int64_t后就用不着了修复case示例:
性能影响:
确实对性能有影响,以
paddle.sum(Tensor([256, 1024, 192, 192], 'float16'), axis=(0, 2, 3))
为例,int版本用时28ms,int64_t版本用时46ms,直接增加60%(当然主要原因是IndexCalculator实现有问题,这个需要另外的PR来修),因此Kernel在调用FastDivMod时需要谨慎评估是否需要使用int64_t的版本Pcard-85711