| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Paddle Tensor 规范化第二期】matrix_rank series of operators supports complex #72286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Paddle Tensor 规范化第二期】matrix_rank series of operators supports complex #72286
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
| char jobz = 'N'; | ||
| int mx = std::max(rows, cols); | ||
| int mn = std::min(rows, cols); | ||
| T* a = const_cast<T*>(x_data); // NOLINT | ||
| int lda = rows; | ||
| int lwork = 3 * mn + std::max(mx, 7 * mn); | ||
| std::vector<phi::dtype::Real<T>> rwork( | ||
| std::max(5 * mn * mn + 5 * mn, 2 * mx * mn + 2 * mn * mn + mn)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么是std::max(5 * mn * mn + 5 * mn, 2 * mx * mn + 2 * mn * mn + mn));?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是lapack库中复数系列函数（sgessd，zgessd）的参数，与svd支持复数中使用的一致，参考链接https://www.netlib.org/lapack/explore-html/df/d22/group__gesdd_ga58d8bb0bce9bb2d6224d1955cef7462c.html#ga58d8bb0bce9bb2d6224d1955cef7462c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
| default_rtol_tensor = phi::Full<RealType, Context>( | ||
| dev_ctx, {1}, static_cast<RealType>(rtol_T)); | ||
| default_rtol_tensor = phi::Multiply<RealType>( | ||
| dev_ctx, default_rtol_tensor, max_eigenvalue_tensor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处单元素的乘法，是否可以用phi::Scale代替？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处单元素的乘法，是否可以用
phi::Scale代替？
ltol同理
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #72286 +/- ##
==========================================
Coverage ? 70.95%
==========================================
Files ? 7
Lines ? 1880
Branches ? 0
==========================================
Hits ? 1334
Misses ? 546
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for skipif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PaddlePaddle#72286) * add complex * fix ci * fix ci * fix * fix * fix * fix * fix * skip xpu ci
PR Category
User Experience
PR Types
Bug fixes
Description
Pcard-75624
为matrix_rank系列算子支持复数