You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
SigureMo
changed the title
[SOT] Always use dummy_guard when fallback error occurred
[SOT] Always use dummy_guard when fallback error occurred
Apr 11, 2025
The removal of the condition checking 'e.disable_eval_frame is False' in strict mode now causes a raise for every case where strict mode is enabled. Please double-check if this behavior is intended in all scenarios; if not, reintroducing a condition or adding a clarifying comment may be appropriate.
Since the conditional assignment of the guard function has been removed, 'dummy_guard' is always used. Consider verifying that components downstream do not rely on the previous behavior using simulator.guard_fn, and if needed, update the documentation or add a comment explaining this change.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
这里针对
disable_eval_frame = True
逻辑不确定原因,可能是过去有别的场景,但目前代码是没有disable_eval_frame = True
的,一旦真的disable_eval_frame = True
会在外部首次 translate guard 不为None
的检查处挂掉,所以这里应该是可以安全删掉的