| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:49:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=275.76965,conversation_content-fragment;desc="conversation_content fragment";dur=1219.749717,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=324.903742,nginx;desc="NGINX";dur=1.245979,glb;desc="GLB";dur=100.12286
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2F%2FXB6i%2FdtKMb3p7M9vBM%2B%2Fvm9QxMTTNyW17Mr4UlKqZYBAUFh9uhmpmnO8gXfK1DumM44ReM5UOLsFFRmgFy%2FkAYHBLlLM1m2%2BvNF9s8cRj8lvWFM5wVIk5VJDIr%2FuxdsHkyIm%2B9Kxd38a48C8EZZEzEhdcWqAEbK2ivpkFHkeRwf9hMB5Ot8UQ7VkDu9izhMCwHcW%2FXlT4nZoWyPMUsNQ9bY0udSa%2B9vDw%2FVLAigJ75%2BOzTp9AfmlU%2B%2FgFb8Vc%2B81KH0iOlC0EjV75Xkmd7kQ%3D%3D--A4D9vd6A8s3WZ7S6--sRqu3xgMwS%2F%2BrLVTLo%2FKQQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.580807426.1753267743; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:49:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:49:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9F7A:35B563:99A994:B990D7:6880BE1F
[SOT][Faster Guard] support `object_equal_stringified_guard` by gouzil · Pull Request #72081 · PaddlePaddle/Paddle · GitHub
[SOT][Faster Guard] support
[SOT][Faster Guard] support
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][Faster Guard] support object_equal_stringified_guard
#72081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
gouzil:feat/add_PyObjMatchGuard
Apr 7, 2025
Merged
[SOT][Faster Guard] support object_equal_stringified_guard
#72081
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
gouzil:feat/add_PyObjMatchGuard
Apr 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/sot/test_faster_guard.py:206
- [nitpick] The function 'test_func' is redefined in the same scope, which may cause confusion in the test. Consider using a distinct name (e.g., 'test_func_redefined') for clarity.
def test_func():
SigureMo
reviewed
Apr 5, 2025
| f"{obj_free_var_name}() is not None and {{}} == {obj_free_var_name}()", | ||
| paddle.framework.core.PyObjMatchGuard(self.get_py_value()), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
SigureMo
reviewed
Apr 6, 2025
paddle/fluid/pybind/sot/guards.h
Outdated
| Py_INCREF(expected_); | ||
| } | ||
|
|
||
| ~PyObjMatchGuard() override { Py_DECREF(expected_); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好家伙，真就直接不 INCREF 存裸指针是吧，话说 weakref 本质上就是存不加引用计数的裸指针吗？
另外，如果是这样的话，使用的时候得检查下是否还存在，如果不存在的话记得报个错
SigureMo
reviewed
Apr 7, 2025
paddle/fluid/pybind/sot/guards.h
Outdated
| @@ -236,6 +236,20 @@ class NumPyArrayValueMatchGuard : public GuardBase { | |||
| PyObject* expected_; | |||
| }; | |||
|
|
|||
| class PyObjMatchGuard : public GuardBase { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| class PyObjMatchGuard : public GuardBase { | |
| class WeakRefMatchGuard : public GuardBase { |
就叫这个吧，和 ValueMatchGuard 作区分
paddle/fluid/pybind/sot/guards.cc
Outdated
| } | ||
|
|
||
| #if PY_3_13_PLUS | ||
| PyObject* referent = NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
referent 是啥，引用吗？应该是 reference 吧？一般直接写 ref 就可以吧
SigureMo
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
SigureMo
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Performance Optimization
PR Types
Performance
Description
NumpyDtypeMatchGuard->NumPyDtypeMatchGuardWeakRefMatchGuard用于对自身进行弱引用，在 check 的时候检查自身是否为 None，并且于传入值相等