You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors and standardizes SOT dynamic shape symbolic operations to ensure that only a limited, well‐defined set of operations (currently on int, float, and bool) are supported. Key changes include:
Removal of operator.not_ from the magic methods mapping.
Introduction of a new module (symbolic_shape.py) defining symbolic types and unified operations.
Updates to symbolic variable handling across opcode translators, dispatchers, trackers, and meta inference modules.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File
Description
python/paddle/jit/sot/utils/magic_methods.py
Removed operator.not_ mapping from magic methods.
python/paddle/jit/sot/symbolic_shape.py
Added definitions for symbolic operations and types.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Devs
Description
重构和规范 SOT 动态 shape 符号化操作,确保操作在一个有限的子集内,且操作封闭(至少目前封闭在
int
、float
、bool
)这里主要分为数学运算和逻辑运算,数学运算是
int | float -> int | float
,而逻辑运算则是int | float -> bool
,因此最终约束节点总会落到逻辑运算节点上(if number
这种也会归结为Ne(number, 0)
)Note
模型上还有点问题