| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:48:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=449.14279,conversation_content-fragment;desc="conversation_content fragment";dur=1909.061023,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=423.339951,nginx;desc="NGINX";dur=1.125572,glb;desc="GLB";dur=100.817581
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=0d2efRhr88L5IO7QyZQnAKyMRtdFyplV7edFD0rvct%2Bo63GLs154AS2hc6YpZ8JhNiRw8jnX9I36PYyNKZNw2XLOnIZ6ECUsLeXoHygyZUsFtzy3TA4mgTahDWf1ZZytMWBmMvuXtX0IP8P0stRNXQX05nD8gHay3GSyu6OnMfnrLh6y2kqeN5QvFjnZsh2kxReA72DZDmrOQqK0boDDkBtz1XgzDSE%2BVMMlfpKtEks9Fd0E0Q6fVtBIvylP5TL0M1i9oX82NjQYCEL09NrFug%3D%3D--rDSWLSCWg4C14uBM--fxNRPffTgsFSkq%2F8OrkZzg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.28753714.1753267695; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:48:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:48:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CB2:351DD4:99631C:B9445E:6880BDEF
[SOT] Non-break support for `paddle.get_device` by SigureMo · Pull Request #72004 · PaddlePaddle/Paddle · GitHub
[SOT] Non-break support for
[SOT] Non-break support for
SigureMo
changed the title
[SOT] Support no breakgraph for
[SOT] Non-break support for Apr 1, 2025
SigureMo
changed the title
[SOT] Non-break support for
[SOT] Non-break support for Apr 1, 2025
SigureMo
changed the title
[SOT] Non-break support for
[SOT][3.13] Non-break support for Apr 1, 2025
SigureMo
changed the title
[SOT][3.13] Non-break support for
[SOT] Non-break support for Apr 1, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Non-break support for paddle.get_device
#72004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 6 commits into
PaddlePaddle:develop
from
cattidea:sot/support-no-breakgraph-for-place-get-device-id
Apr 1, 2025
Merged
[SOT] Non-break support for paddle.get_device
#72004
SigureMo
merged 6 commits into
PaddlePaddle:develop
from
cattidea:sot/support-no-breakgraph-for-place-get-device-id
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for non-breakgraph execution of place.get_device_id by introducing a new PlaceVariable type and updating related dispatchers.
- Introduces PlaceVariable to handle get_device_id operations.
- Registers place_get_device_id within the dispatcher and updates import statements accordingly.
- Removes a redundant line in paddle/device/init.py to clean up duplicate formatting.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/paddle/jit/sot/opcode_translator/executor/variables/basic.py | Adds the PlaceVariable class and implements get_device_id logic. |
| python/paddle/jit/sot/opcode_translator/executor/variables/init.py | Exports the new PlaceVariable. |
| python/paddle/jit/sot/opcode_translator/executor/variable_dispatch.py | Registers place_get_device_id for PlaceVariable. |
| python/paddle/jit/sot/opcode_translator/executor/dispatch_functions.py | Adds a stub for place_get_device_id. |
| python/paddle/device/init.py | Removes a duplicate device string formatting line. |
python/paddle/jit/sot/opcode_translator/executor/variables/basic.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| def place_get_device_id(x): | ||
| pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function 'place_get_device_id' is currently a stub (using 'pass'). If this function is meant to be implemented in this PR, consider raising a NotImplementedError or adding a TODO comment to clarify its intended behavior.
Suggested change
| pass | |
| raise NotImplementedError("place_get_device_id function is not yet implemented.") |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
…ic.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SigureMo
changed the title
place.get_device_idplace.get_device_id
SigureMo
changed the title
place.get_device_idpaddle.get_device
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds non-break support for paddle.get_device by introducing a new PlaceVariable for device dispatching and by updating tests to verify that device switching triggers a rebuild of the graph.
- Added unit tests to validate the new device guard and expected behavior for different device types (cpu, gpu, xpu).
- Added a new PlaceVariable in the opcode translator to support get_device_id and get_device_type dispatch.
- Updated variable dispatch and removed duplicate assignment for IPUPlace in paddle.get_device.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/sot/test_sot_place.py | Added tests for device guard and ensuring graph rebuild after switching device |
| python/paddle/jit/sot/opcode_translator/executor/variables/basic.py | Introduced PlaceVariable and updated import order to support new dispatch functions |
| python/paddle/jit/sot/opcode_translator/executor/variables/init.py | Registered PlaceVariable for use in the translator |
| python/paddle/jit/sot/opcode_translator/executor/variable_dispatch.py | Registered dispatcher functions for PlaceVariable operations |
| python/paddle/jit/sot/opcode_translator/executor/dispatch_functions.py | Added stubs for place_get_device_id and place_get_device_type |
| python/paddle/device/init.py | Removed a duplicate assignment in device string formatting |
|
|
||
|
|
||
| def place_get_device_id(): | ||
| pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function 'place_get_device_id' remains unimplemented. Add an appropriate implementation or provide a comment explaining why it is intentionally left as a stub.
Suggested change
| pass | |
| import paddle | |
| device = paddle.device.get_device() | |
| device_id = int(device.split(':')[-1]) if ':' in device else 0 | |
| return device_id |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Comment on lines
+68
to
+69
| def place_get_device_type(): | ||
| pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function 'place_get_device_type' remains unimplemented. Add an appropriate implementation or provide a comment explaining why it is intentionally left as a stub.
Suggested change
| def place_get_device_type(): | |
| pass | |
| def place_get_device_type(place): | |
| if place.is_gpu_place(): | |
| return "GPU" | |
| elif place.is_cpu_place(): | |
| return "CPU" | |
| else: | |
| raise ValueError("Unsupported place type") |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SigureMo
commented
Apr 1, 2025
gouzil
approved these changes
Apr 1, 2025
SigureMo
changed the title
paddle.get_devicepaddle.get_device
wanghuancoder
approved these changes
Apr 1, 2025
SigureMo
changed the title
paddle.get_devicepaddle.get_device
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
--------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
为
paddle.get_device添加非打断支持，模拟的函数只有CUDAPlace.get_device_id不支持，添加 dispatch 后可以确保无打断，且 guard 能正常工作，切换 place 能重新触发组网