| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:42:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=321.784089,conversation_content-fragment;desc="conversation_content fragment";dur=822.165244,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=349.270292,nginx;desc="NGINX";dur=1.207923,glb;desc="GLB";dur=101.927848
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XRWelJ6osspbBASBySCMozP6HFcjYC5kf0tOzSqlV2NGAfjwYZxdQCs5%2FRjRNAkZI7%2Bu56bYbVY1cX%2BprJsXY0A6PB59%2FDaXA786de5C6t%2FtkZh9T80fkHDe1YyRAl0SSTfoTq44wDdvl91tEEAmC9h9TvYwpGeGnfxyFUDG0hTTyKtPpXfULq66oYbMYf3xeSYH4USi7ML6JJ46cu%2BFpPmAseC9ZSA00X5%2FY0YWH3swTB7vwyG7KG7V9XastnSTWYdTF9ZLYkcMePmaZ3jO0Q%3D%3D--3nmI83m%2BX%2F6ZwZ5v--wRKH1yt7H1TF03gMa6DCoA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1687055110.1753332124; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:42:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:42:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E428:256CA9:1305332:1722CB1:6881B99C
Fix the loop index in Split/Fuse is not less than total loop's number. by baoqiwen · Pull Request #71973 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix the loop index in Split/Fuse is not less than total loop's number. #71973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
ZhangX-21
reviewed
Mar 31, 2025
| } | ||
| } | ||
|
|
||
| std::vector<std::string> TileBroadcastTactic::TileVectorizeNHWC( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当前代码没有支持，是否在下一个PR支持相关特性。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| if (ScheduleBlockEnableVectorize(context_->config, block_id)) { | ||
| ApplyVectorize(sch, block_id); | ||
| return; | ||
| if (applied_layout_ == BroadcastLayout::NCHWLayout) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一个if分支applied_layout_ == BroadcastLayout::NCHWLayout && ScheduleBlockEnableVectorize(context_->config, block_id)是否更加简洁一点。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
ZhangX-21
approved these changes
Mar 31, 2025
lshpku
approved these changes
Apr 1, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
PaddlePaddle#71973) * Fix the loop index in Split/Fuse is not less than total loop's number. * Fix the loop index in Split/Fuse is not less than total loop's number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-89071
原先vectorize在split/fuse时，会出现索引越界的bug：
The loop index in Split should be less than total loop's number.
The loop index in Fuse should be less than total loop's number!
做了FuseAxisGroups(sch, block_id)后，如果原layout是NCHW，则输出到layout是3维[b, p, b]，但是如果是NHWC，则layout是2维[b, p]。
1）当layout是NHWC输出2维时，仍旧用3维的方式去处理split/fuse，出现越界：
resnet50-NHWC网络中，vectorize在NHWC场景下，由于用了过多寄存器，有性能问题。
该patch先做功能修复，TileBroadcastTactic NHWC场景走CINN实现。
后续会尝试通过预测寄存器使用数量来tuner是否打开vectorize，再打开NHWC的vectorize实现。
2）当layout是NCHW输出3维时：
原写法会有一个for循环，该patch做了性能调优。TileBroadcastTactic NCHW时开启vectorize。