| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 18:35:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=1508.877774,conversation_content-fragment;desc="conversation_content fragment";dur=1503.99738,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=678.839203,nginx;desc="NGINX";dur=1.020513,glb;desc="GLB";dur=101.182614
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=mtTmwsuHr88Inpb2RgQHQjE0CNKvyfOi8kAHa7In8MOvSLR34l2XekuKBahHBqav6UadBB0oMJP8y9ceYszgpQRt9ItohOb1YUUL%2FpQLjaWqdBl8SL80Wm3%2BG84JWNnplKzqv0JcO6t5EXdmqsd%2FX0Nvez15KthEFjqsKlyFa0b0PdTKBsk6wjMD8qqB13h4d0N3WEvYlMBtEFf8y%2F6jY%2FCJmGqPSv42np8Ap1mKu4l333TrpAs%2BqRNEQKS4eo24eIouhU0XyArb%2FXUNsABD7A%3D%3D--5mTsWx7NK6oYdOeZ--lNEh665Zq%2BmxUlF2f3kOIA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.50612131.1753295720; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 18:35:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 18:35:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CE0C:221257:12F49:173A9:68812B68
[SOT] Copy cached meta info to avoid got wrong symbol by SigureMo · Pull Request #71971 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Copy cached meta info to avoid got wrong symbol #71971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zrr1999
merged 1 commit into
PaddlePaddle:develop
from
cattidea:sot/copy-cached-meta-info-to-avoid-got-wrong-symbol
Mar 29, 2025
Merged
[SOT] Copy cached meta info to avoid got wrong symbol #71971
zrr1999
merged 1 commit into
PaddlePaddle:develop
from
cattidea:sot/copy-cached-meta-info-to-avoid-got-wrong-symbol
Mar 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a bug in the caching of meta information by introducing deep copy operations to prevent shared mutable SymbolicVariables causing incorrect reuse of meta info in different TensorVariables.
- Introduces a "copy" parameter in the Cache class to enable deep copying on cache hits.
- Adds custom deepcopy implementations for DistInfo and MetaInfo to ensure fresh copies.
- Updates InferMetaCache and LayerInferMetaCache to use deep-copied outputs from the cache.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/paddle/jit/sot/utils/utils.py | Adds a "copy" flag to the Cache class and deep-copy logic when a cache hit occurs. |
| python/paddle/jit/sot/infer_meta.py | Implements custom deepcopy methods for DistInfo and MetaInfo and applies deep copy in caches. |
Comments suppressed due to low confidence (2)
python/paddle/jit/sot/utils/utils.py:271
- [nitpick] The parameter and attribute 'copy' might be confused with the imported 'copy' module. Consider renaming it to 'do_deepcopy' for improved clarity.
def __init__(self, weak=False, copy=False):
python/paddle/jit/sot/infer_meta.py:281
- Ensure that fields such as 'name', 'persistable', 'type', and 'place' in MetaInfo are immutable or intentionally shared; if they are mutable, they should be deep-copied to avoid unintended shared state.
def __deepcopy__(self, memo):
zrr1999
approved these changes
Mar 29, 2025
ggggxm
pushed a commit
to ggggxm/Paddle
that referenced
this pull request
Mar 31, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
#71932 在 MetaInfo 处确保不 copy 新的 shape 来保证同一个
TensorVariable中 shape 里的SymbolicVariable一定是 cache 住的，不会调两次 shape 创建的SymbolicVariable不同但这暴露了另一个问题，因为我们 InferMeta 是有 cache 的，cache 后的 shape 一定是同一个对象，因此一旦两个 TensorVariable 因为 InferMetaCache 命中，那么就会共享同一个
meta.shape了，这就导致这个 list 对应的 data proxy 是同一个，里面的SymbolicVariable也是同一个，就出现了多个TensorVariable的 shape 使用同一个SymbolicVariable的问题比如
这里从 cache 里拿到的符号就错了，其实应该是互不相关的
[S6, S7]因此在
InferMetaCache里加了 copy 参数，在输出前deepcopy一下，以免共享类似可变对象导致错误命中 cache 的问题