| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 11:00:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=426.6693,conversation_content-fragment;desc="conversation_content fragment";dur=1290.621896,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=451.155116,nginx;desc="NGINX";dur=1.091437,glb;desc="GLB";dur=102.164408
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RpImYA8MfAS0bKstuglz3I0epINvUFSa3A4qfmJWzwfeS%2BdX6rDJF0B2c1hxkSF4a90cSDBz7TUW%2FCrx%2F3oZokp%2BJdaPqTd7AfallsWDm%2Bwj5PEv%2FoPJ761%2FS5yMTuNXC3txisby8dp9t%2BAlsCHa6XQUXanIu8TGYWv2AStRorcgJ1z64CYHeXzfyVwe%2F6AkKsEz7EG5riUIaUrkTvqID3p5AhWBtEz6HtAxmyKmd1CH6FWbPnzHBR3tpVybXILVQlB%2B0PY0yi%2BeB1E8KmgCvg%3D%3D--AsbQcfOQAG9WrVv2--qaGlzXsaFVQS66OKYu1WSQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1188522220.1753268446; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:00:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:00:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B99E:20AC8F:9D67DB:BDAF98:6880C0DE
[Prim][CINN] Restore insertion point after decomp by SigureMo · Pull Request #71960 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Prim][CINN] Restore insertion point after decomp #71960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:prim/restore-insertion-point-after-decomp
Mar 28, 2025
Merged
[Prim][CINN] Restore insertion point after decomp #71960
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:prim/restore-insertion-point-after-decomp
Mar 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the insertion point was not restored after running a composite operator in CINN, which caused subsequent cases to run on an incorrect static program. Key changes include adding an explicit paddle.static.program_guard to ensure the insertion point is correctly reset and reformatting argument lists in paddle.strided_slice for improved readability.
Files not reviewed (1)
- paddle/fluid/pybind/pybind.cc: Language not supported
|
/re-run all |
SigureMo
commented
Mar 27, 2025
| int end_index) { | ||
| VLOG(4) << "[Prim] Bind Decomp sinking_decomp begin."; | ||
| py::list res; | ||
| auto original_insertion_point = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就加了这里 save insertion point 和后面恢复两行，不知道为啥全重新格式化了
This was referenced Mar 27, 2025
zyfncg
approved these changes
Mar 28, 2025
ggggxm
pushed a commit
to ggggxm/Paddle
that referenced
this pull request
Mar 31, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
组合算子结束后恢复原来的 insertion point，避免副作用扩散到后续 case
该问题在 CINN 在动转静开默认后
test_slice暴露，前一个动转静 case 因为跑了组合算子，导致后面没用program_guard的纯静态图插入点错误，并不是default_main_program，因此跑（exe.run）了个寂寞（空 program）通过删 backend 相关代码定位到 decomp 问题，加了插入点恢复逻辑
由于静态图单测实际上加
program_guard会更安全些，因此也加了一下Related links
CINN 切默认系列 PR
build_strategy.build_cinn_passand replace it withbackendoption #71815FLAGS_use_cinnviaos.getenv#71817np.testingmodule to get better error message and tolerance settings intest_ifelse#71951