| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 11:01:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=447.785902,conversation_content-fragment;desc="conversation_content fragment";dur=888.4824,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=458.685363,nginx;desc="NGINX";dur=1.486171,glb;desc="GLB";dur=100.943273
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=u3QyEpDuz4q9qY%2FADNs60a%2Fp8NvkKr7zm7mY4qacQHmwRL%2FI1mfnUnYMxiQp1fxb8u1JI9z2GcVNmHXA50RYdh4Ph5cqkRfTtOkDhwenV2M0O0MSmgEhVoVNWffYPYwCDDUZNNuTpghlXRg%2BMOuiF6Z8CnFVRS%2BA3K7cYzardJJ%2FcwsuJuEbW2r1iq94%2BhmMuz%2FSzvgjgcbbPUV0WuPM%2FvgS6PAKNVC%2Be67RHIZoEwc76CsEUqWSYX4aK8IVSNZKyCGirpRA6izmXSFUNvnzKg%3D%3D--12xFEyS9eNgzFdl%2F--%2FjXWRJQPbh2Zd1BTK5dnbw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1807171136.1753268484; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:01:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:01:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C2FC:3B93B0:9EFC2D:BF48F8:6880C104
[SOT] Use same list when create dynamic axes meta to ensure `SymbolicVariable` are same by SigureMo · Pull Request #71932 · PaddlePaddle/Paddle · GitHub
[SOT] Use same list when create dynamic axes meta to ensure
SigureMo
deleted the
sot/use-same-list-when-create-dynamic-axes-meta-to-ensure-symbolic-variable-are-same
branch
March 27, 2025 02:08
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Use same list when create dynamic axes meta to ensure SymbolicVariable are same
#71932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:sot/use-same-list-when-create-dynamic-axes-meta-to-ensure-symbolic-variable-are-same
Mar 27, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Variable` are same
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes a bug related to dynamic shape handling by ensuring that the meta.shape list object remains consistent, which prevents the unintended creation of duplicate SymbolicVariable instances.
- Updated with_dynamic_axes in MetaInfo to clear and extend the existing shape list
- Removed an unnecessary TODO comment in the opcode_translator executor
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/paddle/jit/sot/infer_meta.py | Updated with_dynamic_axes to preserve the shape list object for dynamic variable consistency |
| python/paddle/jit/sot/opcode_translator/executor/dispatcher.py | Removed an outdated TODO comment regarding VAR_KEYWORD support |
gouzil
approved these changes
Mar 26, 2025
SigureMo
deleted the
sot/use-same-list-when-create-dynamic-axes-meta-to-ensure-symbolic-variable-are-same
branch
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Mar 27, 2025
…Variable` are same (PaddlePaddle#71932)
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
…Variable` are same (PaddlePaddle#71932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
应该是 #71771 暴露的新问题
对于动态 shape 场景，我们首先提前触发
tensor.shape从meta.shape构造 shape 对应的ListVariable，并shape_var.proxy.get_all()提前 finalize 所有值，以确保知道哪些是SymbolicVariable，当发现SymbolicVariable时，反过来更新meta.shape，但这里meta.shape的更新是非 inplace 的，是创建一个新的 meta，shape 也是全新的 list，这会导致下一次再次tensor.shape时，重新创建的 data proxy 也是全新的，会再次重新创建SymbolicVariable，由于这次from_value传入的是SymbolicInt，所以会创建一个新的SymbolicVariable，会当成中间产生的符号变量来处理，产生错误的 tracker最终导致在 symbolic fallback to constant 时 disable 该 Symbol 一直没 disable 成功，而且该 cache 还被丢弃了，cache 一直达不到 20，一直触发重复编译
因此本 PR 确保
meta.shape保持是同一个对象，以免创建不同的SymbolicVariable