| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:56:22 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=315.071757,conversation_content-fragment;desc="conversation_content fragment";dur=1295.565759,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=412.217416,nginx;desc="NGINX";dur=1.098943,glb;desc="GLB";dur=100.727034
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=wIJEkPIOeUy9kr6TbTJ9VKWdFzz%2B9pQg%2Fxm0HVX2PMm6d2w8LDo9KI%2BwE0rf1VLnzxHIu%2B2muW9FjenLb5jD11Mwg1paPhiYKs4bQ%2BTEgU2sjh62Z9sycinUAAnW%2BhScdFQAkWbOfhwexK5kXfrorgvLA2JrzLq2j7N9%2FA6UpuTWpWQI3vdXBYpsn2gpK7zohj7NeG5YaD8ONcIoYanMGYqcHzLXtYmyQksOFlkz%2FaFPCoKUOB9hRVMW9dxN%2BGQujNm1sYwtvoupmzc2lZzGFg%3D%3D--zw%2BnYn4Emw%2FFDbwf--oLFXN%2BxXACFNowIB00cnzg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.740776488.1753268180; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:56:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:56:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E6B0:12F48D:9D4325:BD6797:6880BFD4
[SOT][Faster Guard] support `NumpyDtypeMatchGuard` by gouzil · Pull Request #71900 · PaddlePaddle/Paddle · GitHub
[SOT][Faster Guard] support
[SOT][Faster Guard] support
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][Faster Guard] support NumpyDtypeMatchGuard
#71900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zrr1999
merged 7 commits into
PaddlePaddle:develop
from
gouzil:sot/faster_guard_add_NumpyDtypeMatchGuard
Mar 27, 2025
Merged
[SOT][Faster Guard] support NumpyDtypeMatchGuard
#71900
zrr1999
merged 7 commits into
PaddlePaddle:develop
from
gouzil:sot/faster_guard_add_NumpyDtypeMatchGuard
Mar 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for NumpyDtypeMatchGuard to check the consistency of numpy dtypes, enhancing performance guard validation.
- Added unit tests for NumpyDtypeMatchGuard in the test suite.
- Updated guard creation in the stringified guard generation to use FasterStringifiedExpression for performance improvements.
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/sot/test_faster_guard.py | Added tests for checking numpy dtype consistency via NumpyDtypeMatchGuard |
| python/paddle/jit/sot/opcode_translator/executor/variables/basic.py | Replaced StringifiedExpression with FasterStringifiedExpression when constructing dtype and value guards to support the performance optimization |
Files not reviewed (3)
- paddle/fluid/pybind/jit.cc: Language not supported
- paddle/fluid/pybind/sot/guards.cc: Language not supported
- paddle/fluid/pybind/sot/guards.h: Language not supported
Comments suppressed due to low confidence (2)
test/sot/test_faster_guard.py:137
- Consider adding additional test cases for non-numpy inputs or invalid types to further ensure that NumpyDtypeMatchGuard correctly rejects unsupported types.
self.assertTrue(guard_numpy_dtype.check(np.int32()))
python/paddle/jit/sot/opcode_translator/executor/variables/basic.py:1334
- Ensure that FasterStringifiedExpression provides equivalent behavior to the previous StringifiedExpression in the context of constructing dtype guards. If there are any subtle differences, update the related code or tests accordingly.
dtype_guard = FasterStringifiedExpression(
SigureMo
reviewed
Mar 25, 2025
| self.assertTrue(guard_numpy_dtype.check(np.array(1, dtype=np.int32))) | ||
| self.assertTrue(guard_numpy_dtype.check(np.int32())) | ||
| self.assertFalse(guard_numpy_dtype.check(np.array(1, dtype=np.int64))) | ||
| self.assertFalse(guard_numpy_dtype.check(np.float32())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测一下 np.bool_ 呢？
SigureMo
reviewed
Mar 25, 2025
| @@ -137,6 +137,7 @@ def test_numpy_dtype_match_guard(self): | |||
| self.assertTrue(guard_numpy_dtype.check(np.int32())) | |||
| self.assertFalse(guard_numpy_dtype.check(np.array(1, dtype=np.int64))) | |||
| self.assertFalse(guard_numpy_dtype.check(np.float32())) | |||
| self.assertFalse(guard_numpy_dtype.check(np.bool_())) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
别 assertFalse 呀，换一个 guard 实例，测个 assertTrue 的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds performance optimizations for the SOT guard system by introducing support for NumpyDtypeMatchGuard, which checks that two numpy dtypes are equivalent.
- Added tests in test/sot/test_faster_guard.py to verify NumpyDtypeMatchGuard behavior
- Updated guard initialization in python/paddle/jit/sot/opcode_translator/executor/variables/basic.py to use FasterStringifiedExpression with NumpyDtypeMatchGuard and ValueMatchGuard consistently
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/sot/test_faster_guard.py | Adds tests to validate the behavior of NumpyDtypeMatchGuard with various numpy types. |
| python/paddle/jit/sot/opcode_translator/executor/variables/basic.py | Modifies the stringified guard construction to use FasterStringifiedExpression along with the new NumpyDtypeMatchGuard. |
Files not reviewed (3)
- paddle/fluid/pybind/jit.cc: Language not supported
- paddle/fluid/pybind/sot/guards.cc: Language not supported
- paddle/fluid/pybind/sot/guards.h: Language not supported
SigureMo
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
zrr1999
approved these changes
Mar 27, 2025
ggggxm
pushed a commit
to ggggxm/Paddle
that referenced
this pull request
Mar 31, 2025
* [SOT][Faster Guard] support `NumpyDtypeMatchGuard` * fix review * fix review and test build * test build * fix build error * use pyobj * add todo
12 tasks
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* [SOT][Faster Guard] support `NumpyDtypeMatchGuard` * fix review * fix review and test build * test build * fix build error * use pyobj * add todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Performance Optimization
PR Types
Performance
Description
NumpyDtypeMatchGuard支持，用于检查两个 numpy dtype 是否一致