| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 23:50:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=271.628681,conversation_content-fragment;desc="conversation_content fragment";dur=1234.636427,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=360.985298,nginx;desc="NGINX";dur=1.358417,glb;desc="GLB";dur=101.421527
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2Fvl1HyJpciPTjobzHG2X5VJvD5hqlUboy6Il1cCtTy92L1IwsWKNbRxe5w%2Bk9fvIO5pHZsm6FCY1LTABqeGy5gQC0fGauaRqFXaN21P6mKRSYkYto%2FibSZmCAezzjXPvt9edbtEbpvZ5rqiCyjwVAUX4W1kUQd4gUaQheEkFphZrWzGFRvEy4Ki8vPR7MJL1MWOd8V8NH6nnJXOnZjd3D9DJZOL9iG62L%2BueZvpz3fCAUGGiySSY0ecyCiQDovLNhoFnOKBej5b72qNNZv3KfQ%3D%3D--ti7opyS5ZXt8yRA%2B--ioM7TC3sFbJLITYhggxs2w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.498377937.1753487410; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 23:50:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 23:50:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 91E6:3B05D7:36AA0:574F7:68841832
[Dy2St][CINN] Auto enable prim / cinn flag / recompute when backend is CINN by SigureMo · Pull Request #71834 · PaddlePaddle/Paddle · GitHub
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
March 21, 2025 19:33
SigureMo
deleted the
dy2st/auto-enable-prim-cinn-recompute-when-backend-is-cinn
branch
March 25, 2025 02:36
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Dy2St][CINN] Auto enable prim / cinn flag / recompute when backend is CINN #71834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 12 commits into
PaddlePaddle:develop
from
cattidea:dy2st/auto-enable-prim-cinn-recompute-when-backend-is-cinn
Mar 25, 2025
Merged
[Dy2St][CINN] Auto enable prim / cinn flag / recompute when backend is CINN #71834
SigureMo
merged 12 commits into
PaddlePaddle:develop
from
cattidea:dy2st/auto-enable-prim-cinn-recompute-when-backend-is-cinn
Mar 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the Execute Infrastructure by auto-enabling prim, CINN flags, and recompute logic when the backend is CINN. Key changes include replacing string backend comparisons with a new Backend enum, refactoring guard context managers and related functions, and updating tests to align with the new backend API.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| python/paddle/jit/dy2static/utils.py | Introduces environment variables and a new Backend enum with helper methods to differentiate CINN and PHI backends |
| test/deprecated/prim/prim/flags/test_prim_flags_case_deprecated.py | Removes the redundant use_cinn flag in tests and simplifies to use backend=None |
| python/paddle/jit/api.py | Updates to use the new Backend API and removes deprecated backend checks |
| python/paddle/jit/dy2static/program_translator.py | Refactors CINN enabling logic to use Backend.is_cinn() and updates backend_guard usage; removes deprecated string-based checks |
| python/paddle/jit/dy2static/pir_partial_program.py | Updates imports and usage to leverage the new Backend enum |
| test/dygraph_to_static/test_partial_program_hook.py | Passes an explicit Backend value to PirPrimHooker and removes use_cinn flags from test calls |
| python/paddle/jit/dy2static/partial_program.py | Replaces backend string comparisons with Backend.is_cinn() for improved correctness |
Comment on lines
1519
to
1521
| print(core._is_fwd_prim_enabled()) | ||
| with backend_guard(self.backend): | ||
| print(core._is_fwd_prim_enabled()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug print statements appear to be left in production code; please remove or replace them with proper logging.
Suggested change
| print(core._is_fwd_prim_enabled()) | |
| with backend_guard(self.backend): | |
| print(core._is_fwd_prim_enabled()) | |
| logging_utils.info(core._is_fwd_prim_enabled()) | |
| with backend_guard(self.backend): | |
| logging_utils.info(core._is_fwd_prim_enabled()) |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the CINN backend integration for dynamic-to-static conversion by auto-enabling prim/CINN flags, refactoring backend handling, and updating related tests.
- Introduces a Backend Enum with helper methods and updated guard context managers.
- Refactors CINN flag checking and deprecates legacy build_strategy flags in favor of the new backend parameter.
- Updates test cases and related utility functions to remove the old use_cinn parameter.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/paddle/jit/dy2static/utils.py | Adds Backend enum; refactors CINN flag logic and updates warning messages. |
| test/deprecated/prim/prim/flags/test_prim_flags_case_deprecated.py | Removes legacy use_cinn argument in test cases. |
| python/paddle/base/core.py | Updates flag enabling functions using get_flags. |
| python/paddle/jit/api.py | Removes deprecated backend checking and converts backend parameter using Backend enum. |
| python/paddle/jit/dy2static/pir_partial_program.py | Updates backend handling and guard context usage; refactors variable naming for full-graph passes. |
| python/paddle/jit/dy2static/partial_program.py | Updates backend comparison to use Backend enum. |
| test/dygraph_to_static/test_partial_program_hook.py | Revises hook instantiation with a defined Backend instead of None. |
Comments suppressed due to low confidence (1)
python/paddle/jit/dy2static/pir_partial_program.py:1084
- The variable name 'fused_bn_add_act_pass' was changed to 'full_graph_pre_process_pass' later in the diff; please update the comment or the naming in this context for consistency.
fused_bn_add_act_pass = FullGraphPreProcessPass(
| if build_strategy is not None and build_strategy.build_cinn_pass: | ||
| if build_strategy.build_cinn_pass: | ||
| warnings.warn( | ||
| "Use `build_strategy.build_cinn_pass = True` to enable CINN is deprecated, please use `backend = 'CINN'` instead." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the deprecation warning message to reflect that the backend parameter now uses a Backend enum, for example: "please use backend = Backend.CINN instead."
Suggested change
| "Use `build_strategy.build_cinn_pass = True` to enable CINN is deprecated, please use `backend = 'CINN'` instead." | |
| "Use `build_strategy.build_cinn_pass = True` to enable CINN is deprecated, please use `backend = Backend.CINN` instead." |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend.CINN 不暴露给用户，用户仍然用 "CINN" 和 None，Backend.CINN 和 Backend.PHI 是内部类型安全的数据封装
SigureMo
commented
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
老 IR 单测，上次挂了这次又挂了，这里我觉得没必要测 CINN + 老 IR 的 prim 开启状态了，本来 build_strategy 这种设置方式也弃用了，这部分删掉，backend 测试相关逻辑会由 test_jit_backend 单测来承担
…n-backend-is-cinn
zyfncg
approved these changes
Mar 25, 2025
SigureMo
deleted the
dy2st/auto-enable-prim-cinn-recompute-when-backend-is-cinn
branch
This was referenced Mar 25, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
…s CINN (PaddlePaddle#71834) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
确保在 PIR 下，使用
backend="CINN"能与FLAGS_use_cinn=1 FLAGS_prim_all=true FLAGS_prim_enable_dynamic=true有相同的效果新增
ENABLE_CINN_IN_DY2ST用于控制是否开启编译器，ENABLE_CINN_IN_DY2ST=0的话即便设置backend="CINN"也不会生效数据的一致性很重要，如 #71817 所述，能用 C++ flag 获取值的统一用 C++ flag 了（
FLAGS_prim_enable_dynamic、FLAGS_prim_skip_dynamic、FLAGS_use_cinn），用个flag_guard就能确保内部能感知了，维护起来非常方便分阶段暴露问题，本 PR 修复 bug，完善机制，下个 PR 只修改默认值，暴露切默认所带来的问题
Related links
CINN 切默认系列 PR
build_strategy.build_cinn_passand replace it withbackendoption #71815FLAGS_use_cinnviaos.getenv#71817