You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request addresses a bug in the handling of buffer names during the renaming process, ensuring that both original and new names are removed from the no_need_buffer_names when they are present.
Fixes bug where original_name was not removed from no_need_buffer_names even if it was found in fwd_map and bwd_map.
Updates the removal logic to check for an intersection between {original_name, new_name} and no_need_buffer_names.
SigureMo
changed the title
[Dy2St] Update no_need_buffer names if original_name no need buffer
[Dy2St][3.13] Update no_need_buffer names if original_name no need buffer
Mar 7, 2025
SigureMo
changed the title
[Dy2St][3.13] Update no_need_buffer names if original_name no need buffer
[Dy2St] Update no_need_buffer names if original_name no need buffer
Mar 7, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
同 #71099,之前认为只有
new_name
在no_need_buffer_names
里需要删,因为original_name
在 Program 理论上已经找不到了,但fwd_map
和bwd_map
是在 rename 前获取的,因此还是找得到的,这会导致original_name
仍然在no_need_buffer_names
,那么这个 var 仍然会被 gc