| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 13:29:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=427.724033,conversation_content-fragment;desc="conversation_content fragment";dur=1035.297292,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=476.315607,nginx;desc="NGINX";dur=1.269054,glb;desc="GLB";dur=100.980956
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=C9CkUyjCSY8t6NLCklT18EsBh%2FEPGSh0v2mP0I2gweLQ%2Fd9mY%2BDZvLjjWSBZDRQDyjHApOHSWWizL0WfYHJnppeZxpnNDU1njSD%2BToMuc3r9O1a4rhMaabvhQqq5jZP9uuEdseGW1ysWb0auwSsII%2FTDQle%2F6KB%2FFWeZqBAVRouzXJJk9Wn2Ik2pzp7SB5CFXlur3Tl3%2FcOhb0Zwca1AcasSQ50Qe45bjkXW5iKMwKGLy7ljSirAoQpTg5GdBq7GUsDkVBDeQQlUXMDRQ0uxnQ%3D%3D--tcXSqEOgt56BZPLU--Z9ObsuoKoMckdNHVPk566w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1473537645.1753450194; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 13:29:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 13:29:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E882:3FCB1:A0683A:BB618D:688386D2
[Dy2St] Update `no_need_buffer` names if `original_name` no need buffer by SigureMo · Pull Request #71476 · PaddlePaddle/Paddle · GitHub
[Dy2St] Update
[Dy2St] Update
SigureMo
changed the title
[Dy2St] Update
[Dy2St][3.13] Update Mar 7, 2025
SigureMo
changed the title
[Dy2St][3.13] Update
[Dy2St] Update Mar 7, 2025
SigureMo
deleted the
dy2st/update-no-need-buffer-names-after-rename-values-re
branch
March 8, 2025 03:52
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Dy2St] Update no_need_buffer names if original_name no need buffer
#71476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:dy2st/update-no-need-buffer-names-after-rename-values-re
Mar 8, 2025
Merged
[Dy2St] Update no_need_buffer names if original_name no need buffer
#71476
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:dy2st/update-no-need-buffer-names-after-rename-values-re
Mar 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request addresses a bug in the handling of buffer names during the renaming process, ensuring that both original and new names are removed from the no_need_buffer_names when they are present.
- Fixes bug where original_name was not removed from no_need_buffer_names even if it was found in fwd_map and bwd_map.
- Updates the removal logic to check for an intersection between {original_name, new_name} and no_need_buffer_names.
Reviewed Changes
| File | Description |
|---|---|
| python/paddle/jit/dy2static/pir_partial_program.py | Updated the condition to remove both original and new buffer names from the no_need_buffer_names set |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
SigureMo
changed the title
no_need_buffer names if original_name no need bufferno_need_buffer names if original_name no need buffer
gouzil
approved these changes
Mar 7, 2025
SigureMo
changed the title
no_need_buffer names if original_name no need bufferno_need_buffer names if original_name no need buffer
SigureMo
deleted the
dy2st/update-no-need-buffer-names-after-rename-values-re
branch
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
同 #71099，之前认为只有
new_name在no_need_buffer_names里需要删，因为original_name在 Program 理论上已经找不到了，但fwd_map和bwd_map是在 rename 前获取的，因此还是找得到的，这会导致original_name仍然在no_need_buffer_names，那么这个 var 仍然会被 gc