| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:02:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=322.218875,conversation_content-fragment;desc="conversation_content fragment";dur=677.314492,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=372.510556,nginx;desc="NGINX";dur=0.874242,glb;desc="GLB";dur=101.231182
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=48CiwBi7Hdo%2BCtCRoQ%2F4b36eca2m9mJGlYFbJ9MnxpyEILsWG%2B%2BHt56WV%2FxrTvbAGUQAWHKDNwwGX5qJiQ9bEFA3n0Bp%2Bs0KVuoNRNQqP4tILdBNgs9ZKQaSTCXEiPxDbmOEzE8GzYqQrArzC8Cp%2BfU9k7m21YS3AlwZTNaqb%2FM8VTtIUGEGm8TKmouSc%2BmkORo8EJuhUjP4dXEk9g6bGfiXAUhf%2F1SvacItnM4kHEBIz1a2ZKiCL19QMYzBa96yn8OlTM2sWYeaxq%2F%2Ff5b6Ng%3D%3D--zUQhb4sR6enGwbB%2F--iZIF0SaMQNWBMteLSrB68A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2147192033.1753304551; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:02:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:02:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8BCA:3F8A98:F7298:145F3C:68814DE7
[Dy2St] Custom deepcopy behavior for `WeakMethod` to ensure hold correct instance by SigureMo · Pull Request #71463 · PaddlePaddle/Paddle · GitHub
[Dy2St] Custom deepcopy behavior for
[Dy2St] Custom deepcopy behavior for
SigureMo
changed the title
[Dy2St] Custom deepcopy behavior for
[Dy2St][3.13] Custom deepcopy behavior for Mar 6, 2025
SigureMo
changed the title
[Dy2St][3.13] Custom deepcopy behavior for
[Dy2St] Custom deepcopy behavior for Mar 7, 2025
SigureMo
deleted the
dy2st/custom-deepcopy-for-weakmethod-to-ensure-hold-correct-instance
branch
March 7, 2025 01:09
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Dy2St] Custom deepcopy behavior for WeakMethod to ensure hold correct instance
#71463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:dy2st/custom-deepcopy-for-weakmethod-to-ensure-hold-correct-instance
Mar 7, 2025
Merged
[Dy2St] Custom deepcopy behavior for WeakMethod to ensure hold correct instance
#71463
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:dy2st/custom-deepcopy-for-weakmethod-to-ensure-hold-correct-instance
Mar 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
WeakMethod to ensure hold correct instanceWeakMethod to ensure hold correct instance
gouzil
approved these changes
Mar 6, 2025
SigureMo
changed the title
WeakMethod to ensure hold correct instanceWeakMethod to ensure hold correct instance
SigureMo
deleted the
dy2st/custom-deepcopy-for-weakmethod-to-ensure-hold-correct-instance
branch
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
#71336 的后续，确保
convert_call时候对 forward 绑定的WeakMethod的 instance 是正确的，不应该是之前的，应该也是 deepcopy 之后的Tip
后续发版后有时间可以考虑消除
convert_call产生的 side effect，替换内层 forward 属实有点难看（顶层是 API 层面改不动，内层我觉得完全可以改），可以考虑_jst.Call(fn)(args)改为_jst.Call(fn, args)，以对fn调用的全面接管（原来的_jst.Call和_jst.Ld有点重复了），调用时可以在 patch guard 下（比如 #69936 里的 patch restorer 机制），调用完就恢复或者
_jst.Call(fn)返回一个 ProxyLayer，只用来调用，反正语法层面这里一定是会调用的，不会做别的事情（会有什么问题么？暂时没想到）