[SOT] Split `InlineCallBreak` #71458

DrRyanHuang · 2025-03-06T07:43:57Z

PR Category

Execute Infrastructure

PR Types

Improvements

Description

Refining the InlineCallBreak class into three distinct subclasses to properly differentiate between error types:

FallbackInlineCallBreak: For handling FallbackError cases
BreakGraphInlineCallBreak: For handling BreakGraphError scenarios
OtherInlineCallBreak: For handling all other error types

Removing the UnspecifiedBreakReason class to enforce more explicit error reporting

Now requires passing a concrete reason class (derived from BreakGraphReasonBase) when raising a BreakGraphError
String-only error messages are no longer accepted, improving error traceability and handling

graph LR
    BREAK[BreakGraphReasonBase] ==> DATA[[DataDependencyBreak]]
    BREAK ==> UNSUPPORTED[[UnsupportedOperationBreak]]
    BREAK --> INLINE[[InlineCallBreak]]
    BREAK ==> SIDE[[SideEffectBreak]]
    BREAK --> DYGRAPH[[DygraphInconsistentWithStaticBreak]]
    BREAK --> PSDB[[PsdbBreakReason]]
    BREAK --> INFER[[InferMetaBreak]]
    DATA ==> CONTROL_FLOW[DataDependencyControlFlowBreak]
    DATA ==> DYNAMIC_SHAPE[DataDependencyDynamicShapeBreak]
    DATA ==> OPERATION[DataDependencyOperationBreak]
    UNSUPPORTED ==> API[UnsupportedPaddleAPIBreak]
    UNSUPPORTED ==> BUILTIN[BuiltinFunctionBreak]
    INLINE ==> BREAKGRAPHINLINE[BreakGraphInlineCallBreak]
    INLINE ==> FALLBACKINLINE[FallbackInlineCallBreak]
    INLINE ==> OTHERINLINE[OtherInlineCallBreak]
    SIDE ==> ITERATOR[UnsupportedIteratorBreak]
    style BREAK fill:#f9f9f9,stroke:#333,stroke-width:2px
    style DATA stroke:#0066cc
    style UNSUPPORTED stroke:#cc3300
    style CONTROL_FLOW stroke:#009973
    style DYNAMIC_SHAPE stroke:#009973
    style OPERATION stroke:#009973
    style API stroke:#cc3300
    style BUILTIN stroke:#cc3300
    classDef base fill:#e6f3ff,stroke:#004c99
    classDef data fill:#e6ffff,stroke:#006600
    classDef inline fill:#aaffe6,stroke:#001100
    classDef unsupported fill:#ffe6e6,stroke:#660000
    class SIDE,ITERATOR base
    class DATA,CONTROL_FLOW,DYNAMIC_SHAPE,OPERATION data
    class UNSUPPORTED,API,BUILTIN unsupported
    class INLINE,BREAKGRAPHINLINE,FALLBACKINLINE,OTHERINLINE inline

Python example:

import paddle
from paddle.jit.sot.psdb import breakgraph, fallback
# Simulate subgraph interruption
def func_breakgraph(tensor):
    tensor = tensor + 1
    breakgraph()
    return tensor + 1
def teste(e):
    return func_breakgraph(e)
def testd(d):
    return teste(d)
def testc(c):
    return testd(c)
def testb(b):
    return testc(b)
def testa(a):
    return testb(a)
def fn(a):
    a = a + 1
    a = a + 1
    a = testa(a)
    a = a * 2
    a = a + 1
    return a
static_fn = paddle.jit.to_static(fn, full_graph=False)
x = paddle.to_tensor([1.0, 2.0], dtype="float32")
out = static_fn(x)
print(out)

SOT_LOG_LEVEL=3 \
CUDA_VISIBLE_DEVICES=2 \
PYTHONPATH=/workspace/Paddle/build/python \
MIN_GRAPH_SIZE=0 \
SOT_COLLECT_INFO="subgraph_info[], breakgraph_reason" \
python test_sot.py >  xxxx.log

Log:

......
[Translate Inline]: (line   8) CALL_FUNCTION 0, stack is [UserDefinedFunctionVariable(breakgraph, object_178, breakgraph)]
[BreakGraph] call function Break graph:
    File "/workspace/tmp/test_sot.py", line 28, in testa encountered breakgraph error caused by
    File "/workspace/tmp/test_sot.py", line 24, in testb encountered breakgraph error caused by
    File "/workspace/tmp/test_sot.py", line 20, in testc encountered breakgraph error caused by
    File "/workspace/tmp/test_sot.py", line 16, in testd encountered breakgraph error caused by
    File "/workspace/tmp/test_sot.py", line 12, in teste encountered breakgraph error caused by
    File "/workspace/tmp/test_sot.py", line 6, in func_breakgraph encountered breakgraph error caused by
    breakgraph by psdb.breakgraph
start subgraph compile and execution.
StatementIR: SIR_0
......

PCard-66972

…develop

… develop

paddle-bot · 2025-03-06T07:44:02Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

python/paddle/jit/sot/utils/exceptions.py

SigureMo

昨天忘提交了

SigureMo · 2025-03-06T11:21:34Z

python/paddle/jit/sot/utils/exceptions.py

-            # if reason is a string, then create a UnspecifiedBreakReason object
-            reason = UnspecifiedBreakReason(reason)
+        if not isinstance(reason, BreakGraphReasonBase):
+            raise ValueError(


后续改成 TypeError

SigureMo · 2025-03-06T11:21:45Z

python/paddle/jit/sot/utils/exceptions.py

@@ -191,12 +197,14 @@ def __init__(self, msg, disable_eval_frame=False):

 # raise in inline function call strategy.
 class BreakGraphError(SotErrorBase):
-    def __init__(self, reason: BreakGraphReasonBase | str = None):
+    def __init__(self, reason: BreakGraphReasonBase = None):


Suggested change

def __init__(self, reason: BreakGraphReasonBase = None):

def __init__(self, reason: BreakGraphReasonBase):

这里不要了吧

DrRyanHuang added 9 commits March 3, 2025 13:31

fix lost error info

69e82a3

Merge branch 'develop' of https://github.com/drryanhuang/Paddle into …

9698629

…develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

a857edd

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

a7c345b

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

f40f7b3

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

efa500d

… develop

rm UnspecifiedBreakReason && split InlineCallBreak

861f344

add type check

814e42e

add not

6945cd0

paddle-bot bot added the contributor External developers label Mar 6, 2025

DrRyanHuang changed the title ~~[SOT] Split InlineCallBreak~~ [SOT][3.13] Split InlineCallBreak Mar 6, 2025

refine error

9be52c0

DrRyanHuang commented Mar 6, 2025

View reviewed changes

python/paddle/jit/sot/utils/exceptions.py Show resolved Hide resolved

DrRyanHuang added 2 commits March 6, 2025 10:31

roll back exception_class err info

2b6949d

opt [BreakGraph] call function

ccb51d5

SigureMo approved these changes Mar 7, 2025

View reviewed changes

DrRyanHuang requested a review from SigureMo March 7, 2025 06:16

SigureMo merged commit fecaa1c into PaddlePaddle:develop Mar 7, 2025
31 of 32 checks passed

SigureMo changed the title ~~[SOT][3.13] Split InlineCallBreak~~ [SOT] Split InlineCallBreak Mar 7, 2025

DrRyanHuang deleted the exception branch March 7, 2025 06:19

YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025

[SOT] Split InlineCallBreak (PaddlePaddle#71458)

1ac4109

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SOT] Split `InlineCallBreak` #71458

[SOT] Split `InlineCallBreak` #71458

Uh oh!

DrRyanHuang commented Mar 6, 2025 •

edited

Loading

Uh oh!

paddle-bot bot commented Mar 6, 2025

Uh oh!

Uh oh!

SigureMo left a comment

Uh oh!

SigureMo Mar 6, 2025

Uh oh!

SigureMo Mar 6, 2025

Uh oh!

Uh oh!

Uh oh!

	def __init__(self, reason: BreakGraphReasonBase = None):
	def __init__(self, reason: BreakGraphReasonBase):

[SOT] Split InlineCallBreak #71458

[SOT] Split InlineCallBreak #71458

Uh oh!

Conversation

DrRyanHuang commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Mar 6, 2025

Uh oh!

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

SigureMo Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

SigureMo Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[SOT] Split `InlineCallBreak` #71458

[SOT] Split `InlineCallBreak` #71458

DrRyanHuang commented Mar 6, 2025 •

edited

Loading