| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:22:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=310.085635,conversation_content-fragment;desc="conversation_content fragment";dur=868.201763,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=326.821725,nginx;desc="NGINX";dur=0.790825,glb;desc="GLB";dur=101.800773
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XUnS8Qjn91PG4yPmg5aGedcrJG%2FZRLih79DTBJbZKFHrG4%2FD5%2FQ%2Bu%2FZZx0kpgdqmL7yo0CmBqJ50wt1rW9LiiU0hJDiKhProzvMaDt6HAfi4%2F3t7y5UY8rVz5bIZ5hqwMJUOl3iHKPWlXNmtjhRjlcMI79WvAFrKlobM0dds1VoUT%2B9cFWgMXSKPoqXaqO%2FDzStApiL9kpaZpukqAoPJt%2BlzaWJd9Zs%2F4taFYlsmZO7IufPwdQ%2BlUNkg3fL%2FLfooiv%2FZbQMYY4NVC6Ei1BCmsw%3D%3D--MUvMWxh6%2BMaA3oa8--w%2FM%2FdHxv4yAtzdMEtokoXQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1815633595.1753330921; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:22:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:22:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 953A:36F97A:12E5BF9:16F97CB:6881B4E9
[Serde] Ensure run save hook under dygraph mode by SigureMo · Pull Request #71400 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[Serde] Ensure run save hook under dygraph
[Serde][3.13] Ensure run save hook under dygraph
Mar 4, 2025
SigureMo
changed the title
[Serde][3.13] Ensure run save hook under dygraph
[Serde] Ensure run save hook under dygraph
Mar 5, 2025
SigureMo
changed the title
[Serde] Ensure run save hook under dygraph
[Serde] Ensure run save hook under dygraph mode
Mar 5, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Serde] Ensure run save hook under dygraph mode #71400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:serde/ensure-run-save-hook-under-dygraph
Mar 5, 2025
Merged
[Serde] Ensure run save hook under dygraph mode #71400
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:serde/ensure-run-save-hook-under-dygraph
Mar 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR fixes a bug related to saving model parameters under dygraph mode by ensuring that the save hook runs in the correct context, and updates related error messages and tests.
- Added a new simple model and corresponding tests for the save dtype functionality.
- Wrapped the save hook in a dygraph guard in the auto_cast module.
- Updated error messaging in the data feeder to better reflect the dygraph mode requirements.
Reviewed Changes
| File | Description |
|---|---|
| test/legacy_test/test_jit_save_load.py | Added tests for the new save_dtype functionality and model decoration. |
| python/paddle/amp/auto_cast.py | Wrapped save hook call with a dygraph guard to ensure proper context. |
| python/paddle/base/data_feeder.py | Updated the error message to refer to dygraph mode and corrected terminology. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
python/paddle/amp/auto_cast.py:738
- [nitpick] Consider adding a comment explaining the purpose of using the dygraph guard with Tracer(), to clarify its necessity and ensure maintainability.
with paddle.base.framework._dygraph_guard(paddle.base.dygraph.Tracer()):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
xiaoguoguo626807
approved these changes
Mar 4, 2025
SigureMo
changed the title
SigureMo
changed the title
SigureMo
changed the title
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
--------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
--------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
Fixes #71356，确保 save hook 在动态图执行
PCard-66972