| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:25:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=474.081609,conversation_content-fragment;desc="conversation_content fragment";dur=1514.679822,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=384.035798,nginx;desc="NGINX";dur=0.636384,glb;desc="GLB";dur=102.180456
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=3pyPGD0FY5cw4igNjzw5BM9wEqpditCX3VEUF4mAKpZT06B6xYSKlgh1r%2Frckyf3SjtEELCQsjjPYaZ0LwBThFqIzjTtrcvaPxRFVYB8ovgaKG0Z6yOy54FtyXs7Wc1ImbN8lZjXgPasKbQkI08vIKulTrcmxQuzVSO%2FKfPTPwG7rNk8vODRH31RujtTUUw%2BwmHo42FJygij%2B4JL9yJsssDQo5Gnsg2EYMm14ZegY5bu896XVznfh0Am%2Be9oLadglieQvZOEbPai3P87a1yTfg%3D%3D--3vhAc9%2FlqPgJJHdd--jp177%2FSjKypzU8S1%2F9010g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1730275898.1753331134; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:25:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:25:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EB00:941DF:12DCCFD:16F2493:6881B5BE
【Paddle TensorRT】fix PaddleX pir-trt 3 by lizexu123 · Pull Request #71287 · PaddlePaddle/Paddle · GitHub
lizexu123
changed the title
Revert "【Old trt】add yolo_box dynamic converter"
【Paddle TensorRT】fix PaddleX pir-trt 3
Feb 27, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Paddle TensorRT】fix PaddleX pir-trt 3 #71287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lizexu123
changed the title
YuanRisheng
reviewed
Mar 5, 2025
Comment on lines
1702
to
1719
| auto *first_def_op = size_tensor.defining_op(); | ||
| bool found_shape_op = false; | ||
| auto operand0 = first_def_op->operand_source(0); | ||
| auto *second_def_op = operand0.defining_op(); | ||
| if (first_def_op && first_def_op->isa<paddle::dialect::ShapeOp>()) { | ||
| found_shape_op = true; | ||
| } else if ((first_def_op->name().find("builtin.combine") != | ||
| std::string::npos) && | ||
| (second_def_op->isa<paddle::dialect::DataOp>())) { | ||
| found_shape_op = true; | ||
| } | ||
| if (!found_shape_op && first_def_op && first_def_op->num_operands() > 0) { | ||
| if (operand0.impl()) { | ||
| if (second_def_op && second_def_op->isa<paddle::dialect::ShapeOp>()) { | ||
| found_shape_op = true; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
简化一下判断逻辑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Comment on lines
+965
to
+973
| std::vector<std::string> size_tensor_names = desc.Input("SizeTensor"); | ||
| for (const auto& tensor_name : size_tensor_names) { | ||
| auto* var_desc = block->FindVarRecursive(tensor_name); | ||
| if (!var_desc) continue; | ||
| if (tensor_name.find("shape") != std::string::npos) { | ||
| valid_source = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里逻辑不太合理，建议加点注释，说明是针对特定场景
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
YuanRisheng
reviewed
Mar 5, 2025
| @@ -57,7 +57,6 @@ DEFINE_GENERAL_PATTERN(Reshape, paddle::dialect::ReshapeOp) | |||
| DEFINE_GENERAL_PATTERN(Dropout, paddle::dialect::DropoutOp) | |||
| DEFINE_GENERAL_PATTERN(Bmm, paddle::dialect::BmmOp) | |||
| DEFINE_GENERAL_PATTERN(Concat, paddle::dialect::ConcatOp) | |||
| DEFINE_GENERAL_PATTERN(Nonzero, paddle::dialect::NonzeroOp) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nonzero的不用删了，我已经完善机制了，可以进trt了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| @@ -2914,7 +2945,6 @@ class TrtOpMarkerPass : public pir::PatternRewritePass { | |||
| ADD_PATTERN(Conv2d) | |||
| ADD_PATTERN(FusedConv2dAddAct) | |||
| ADD_PATTERN(DepthwiseConv2d) | |||
| ADD_PATTERN(Nonzero) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上，已不用删
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
YuanRisheng
reviewed
Mar 5, 2025
Comment on lines
1707
to
1725
| auto *first_def_op = size_tensor.defining_op(); | ||
| std::vector<std::string> upstream_op_names; | ||
| if (first_def_op) { | ||
| upstream_op_names.push_back(first_def_op->name()); | ||
| if (first_def_op->num_operands() > 0) { | ||
| auto second_input = first_def_op->operand_source(0); | ||
| if (second_input.impl()) { | ||
| auto *second_def_op = second_input.defining_op(); | ||
| if (second_def_op) { | ||
| upstream_op_names.push_back(second_def_op->name()); | ||
| } | ||
| auto third_input = second_def_op->operand_source(0); | ||
| if (third_input.impl()) { | ||
| auto *third_def_op = third_input.defining_op(); | ||
| upstream_op_names.push_back(third_def_op->name()); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段代码太复杂了，改成这样呢：
auto *first_def_op = size_tensor.defining_op();
std::vector<std::string> upstream_op_names;
upstream_op_names.push_back(first_def_op->name());
if (first_def_op->num_operands() > 0 && first_def_op->operand_source(0).impl()) {
auto second_input = first_def_op->operand_source(0);
auto *second_def_op = second_input.defining_op();
upstream_op_names.push_back(second_def_op->name());
if (second_def_op->num_operands() > 0 && second_def_op->operand_source(0).impl()) {
auto third_input = second_def_op->operand_source(0);
auto *third_def_op = third_input.defining_op();
upstream_op_names.push_back(third_def_op->name());
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以
YuanRisheng
approved these changes
Mar 7, 2025
XieYunshen
approved these changes
Mar 7, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* fix trt model bugs * fix bugs * fix inplace bugs * fix * fix * fix * fix * fix slice * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * code-style * fix * fix --------- Co-authored-by: YuanRisheng <yuanrisheng@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Inference
PR Types
Bug fixes
Description
Pcard-71500
修复内容:
[02/27/2025-04:08:58] [TRT] [E] 4: [shapeCompiler.cpp::evaluateShapeChecks::1276] Error Code 4: Internal Error (kOPT values for profile 0 violate shape constraints: (Unnamed Layer* 36) [Slice]: ISliceLayer has out of bounds access on axis 1 Condition '<' violated: 501 >= 501.)