CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:10:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=385.757977,conversation_content-fragment;desc="conversation_content fragment";dur=1079.631535,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=360.77449,nginx;desc="NGINX";dur=1.548472,glb;desc="GLB";dur=101.169521
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=hdxzfZ6Lu4dQ%2FYIHabT02GQqc3PMv4pkv6Imi7XhiO243vVJc8RsxDOLSIejSPF2n5YmZK7Ny1mYcYaqOdAr%2BX9Ant5ISDKqIgsQ6uRa%2BAEtXwnrfmRitIPpMtiHvd1VZoA28PnxTN3LpoY5mca1GF8a3IDai268WLYZnQ%2BZTSLbkGOR%2FzfzP4pWDUHs0Uq8BbENyb9T2JMuV%2BOZqKsU609hxn8spwv3h9bFmbtxbdwHGNQRBnIlSEbLlvF5j5%2FCMMJjErYmuRZtXz8%2B5dFzFQ%3D%3D--5tsiuXA3ym4ikDZ%2F--Gpc3EhWohpm4cxyYQ%2BObMA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1272607601.1753305033; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:10:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:10:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E6A2:33F9F4:10BF78E:13F6BD5:68814FC9
[Dy2St] Skip early gc if while body use external inputs by SigureMo · Pull Request #71156 · PaddlePaddle/Paddle · GitHub
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
February 17, 2025 08:34
SigureMo
changed the title
[Dy2St] Ensure while op body use block arg if its an input
[Dy2St] Skip early gc if while body use external inputs
Feb 17, 2025
SigureMo
deleted the
dy2st/ensure-while-op-body-use-block-arg-if-its-a-input
branch
February 18, 2025 06:38
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Dy2St] Skip early gc if while body use external inputs #71156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 3 commits into
PaddlePaddle:develop
from
cattidea:dy2st/ensure-while-op-body-use-block-arg-if-its-a-input
Feb 18, 2025
Merged
[Dy2St] Skip early gc if while body use external inputs #71156
SigureMo
merged 3 commits into
PaddlePaddle:develop
from
cattidea:dy2st/ensure-while-op-body-use-block-arg-if-its-a-input
Feb 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
zhangbo9674
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
同 #71145 要解决的问题一样
对于上述代码,我们会转写类似如下的形式:
值得注意的是,这里在 block 外直接使用了
__it
直接引用了y
,这导致了后续在 block 开始时 cond 里引用的y
还是 block 外的 Value,而y
同时又是写的变量,因此其作为了 while op 的输入而 while instruction 有一个 early gc 的逻辑,在 while 执行开始时,会将后续用不到的 inputs 都 gc 掉,但实际上 while block 内是直接使用了
y
的外部变量的(非 block arg),而这里 early gc 的假设是如果一个 block body 使用了输入,那么一定使用的是 block arg 而不是外部变量,因而触发了 early gc 导致了后续使用外部变量时 holder 为空#71145 尝试从转写层面解决该问题,但很难做到完善,
因此本 PR 尝试使用 pass 来解决该问题本 PR 修改 early gc 逻辑,当 loop body 内仍然有 user 时跳过 early gc
closes #71145
PCard-66972