| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:46:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=315.479202,conversation_content-fragment;desc="conversation_content fragment";dur=992.522464,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=345.186719,nginx;desc="NGINX";dur=1.047552,glb;desc="GLB";dur=101.259632
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=qx4t4PBdE4sY1WrPV33KRN1HEF%2FIwrz7iT15r8%2FUOS3igBJ6NGYmGPQxGMflDZVkBnU%2B%2BH37TUHvkvBaLrw4hX%2Bu6TYt9cY1Ehqhtz6pnZHhSZMi36Y1OcUJlcO9ScghLOhcRvwZJKdEzHob%2FT6%2FAcqtXqdx%2BxaZvzLJQHZOApQoWJP8dlFIafCehjd284TjH%2FcHHAgCco%2BS96a6sUo0nOcupPxFruydlieiWNKnW0GhIyd2qPnXXNr0gULqH4yNiMAdMFg6%2BFEV9QmuEB1v3g%3D%3D--CgRyNVdFYtiObhoF--NFNzC%2By0q6z5EN8L8vsS3Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.112438740.1753400780; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E7DE:1256D3:1D636:2E505:6882C5CC
【custom】split device file by xiaoguoguo626807 · Pull Request #71085 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【custom】split device file #71085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xiaoguoguo626807
merged 2 commits into
PaddlePaddle:develop
from
xiaoguoguo626807:custom_part3
Feb 12, 2025
Merged
【custom】split device file #71085
xiaoguoguo626807
merged 2 commits into
PaddlePaddle:develop
from
xiaoguoguo626807:custom_part3
Feb 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbo9674
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhangbo9674
reviewed
Feb 12, 2025
| @@ -1174,20 +1174,20 @@ headers = ( | |||
| list(find_files('token.h','@PADDLE_SOURCE_DIR@/paddle/pir/src/core/parser/'))+ | |||
| #pir ops and dependency | |||
| list(find_files('pd_op.h','@PADDLE_BINARY_DIR@/paddle/fluid/pir/dialect/operator/ir/'))+ | |||
| list(find_files('utils_defs.h','@PADDLE_SOURCE_DIR@/paddle/fluid/ir_adaptor/translator/'))+ | |||
| list(find_files('pd_op_sig.h','@PADDLE_SOURCE_DIR@/paddle/fluid/ir_adaptor/translator/'))+ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup.py 看下是否需要同步修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup.py 下个PR 修改
zyfncg
reviewed
Feb 12, 2025
| #pragma once | ||
| #include <memory> | ||
|
|
||
| #include "glog/logging.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
头文件里不能带glog这样的三方库头文件，外部编译的时候可能会引起链接错误
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该头文件中实现和定义在一起，需要这个glog
Comment on lines
+14
to
+21
| #include "paddle/phi/backends/context_pool.h" | ||
| #include "paddle/phi/backends/cpu/cpu_context.h" | ||
| #include "paddle/phi/backends/custom/custom_context.h" | ||
| #include "paddle/phi/backends/device_ext.h" | ||
| #include "paddle/phi/backends/gpu/gpu_decls.h" | ||
| #include "paddle/phi/common/place.h" | ||
| #include "paddle/phi/core/device_context.h" | ||
| #include "paddle/phi/core/enforce.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有用到的头文件是不可以删一删
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单独提PR整理下
|
|
||
| #include "glog/logging.h" | ||
| #include "paddle/phi/core/platform/device_type.h" | ||
| #include "paddle/utils/test_macros.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_macros.h是否有用到？
zyfncg
approved these changes
Feb 12, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* split device file * fix path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
pcard-67164
拆分device_context.h device_event.h
修改set_up.py错误的路径