| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:46:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=340.979803,conversation_content-fragment;desc="conversation_content fragment";dur=885.441546,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=309.682705,nginx;desc="NGINX";dur=1.489774,glb;desc="GLB";dur=101.053732
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=WEy%2Bz6o3bZBgp0T2NFP9YTAHEQMFmeKb8xdgRME%2FR%2FrOhFJiDb89Z6FB25IBYzsE0k%2Fg3rjSIULOvagH9AfeY5epoIQgOQg8tHL7mcTYec3bVNJ%2BkZtJbqOB8W4r2Rssz2gSM6xUDqA1SUuOeW3XAW3fmGLIBWVSK2jFdjrXOGPN76fxXWlGVCjxOlq9BqlJp6pCumnlpaiIE1zobmX1MoX0Ns5iW5LmjPhjpl9LPG2MgcI%2FAnnBbAV%2B1QOn8RJTm9qU1KYKvYe0iAvyO31kbw%3D%3D--c1mzxNTXi2ydGv9p--zsyXacIZQyshKhxzNBRGow%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.68874552.1753400809; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8406:2D5B28:1DCF2:2F0D5:6882C5E9
[CINN] Fix TileTransposeTactic error on unit loops by lshpku · Pull Request #71068 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN] Fix TileTransposeTactic error on unit loops #71068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
approved these changes
Feb 10, 2025
Comment on lines
+301
to
+302
| if (GetLoopRangeProduct(loops, GetSrcLowAxis(perm)) == 1) continue; | ||
| if (GetLoopRangeProduct(loops, GetDstLowAxis(perm)) == 1) continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果动态维度在运行时是1，会不会有影响？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
动态不会，这个问题的原因是静态的时候range是1，导致loop直接被消除了，于是循环变量丢失；如果动态的话loop range不确定，就不会被消除；所以这个问题还是挺隐蔽的，跟那个EliminateInvariantLoop是联动的
zyfncg
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这类case后面再补几个单测吧
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Bug fixes
Description
修复TileTransposeTactic在处理对unit-loop（extent为1的loop）进行transpose的 “伪transpose” 时的错误
以下场景经测试可以正确运行：
说明：该问题比较隐蔽，在有unit-loop的情况下输入size还必须大于256才能出现，之前只测了 [1, 256] => [256, 1] 的情况，因此未发现该问题
TODO
本PR只是通过判断unit-loop把伪transpose的情况拦下来（低维为unit-loop不行，高维为unit-loop可以）；但有一些含有unit-loop的情况反而是真transpose，之前以及现在都还不能处理，或者处理得不好，比如：
Pcard-85711