CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【custom】split Custom depend header #71036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【custom】split Custom depend header #71036
Conversation
This reverts commit 0ea393b.
你的PR提交成功,感谢你对开源项目的贡献! |
9cd34ef
to
a751e83
Compare
|
||
constexpr int kEmptyVarIndex = 0; | ||
|
||
struct EventInter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_executor_def 中原本定义了两类数据结构:一类是 Instruction 的成员,一类是 Interpreter 用到的成员,这个 new_executor_base_def.h 建议直接迁移到 instruction 目录下,改成 instruction_def.h 吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for setup.py.in
@@ -0,0 +1,52 @@ | |||
// Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021 -> 2025
@@ -0,0 +1,45 @@ | |||
// Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023 -> 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些文件是移动,不是新建,所以没改创建日期
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [custom] dependency for custom_engine * add extention * add .cc * add declear * [GCU] Open more information for instruction * revert fix * Revert "add extention" This reverts commit 0ea393b. * fix conflict * recover pd_op_to_kernel_pass * modify setup.py * fix build * fix build * ercover deviceevent * modify header name * modify xpu build * delete // * rename new_executor_base_defs.h * rename new_executor_base_defs.h --------- Co-authored-by: EnflameGCU <118410644+EnflameGCU@users.noreply.github.com>
PR Category
Execute Infrastructure
PR Types
Improvements
Description
pcard-67164
拆解部分头文件,避免暴露pir 无关的头文件