| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:05:30 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=456.094218,conversation_content-fragment;desc="conversation_content fragment";dur=2522.342125,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=469.245924,nginx;desc="NGINX";dur=0.675461,glb;desc="GLB";dur=101.518441
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2FtoRNIDKqSoarLsASi9m0b8Cyg3oIFXbQnvSRPltWy%2BS8EktTc958KNmo65C%2FDaB2J%2BNwDVpowtGIkZTCJ2iepv%2F3w76somoTNND4kZesfjOdQWXau30AjyVrBJkXTGghLMHAKFqedagzIpw%2BcWYDxuj5dgHup9UEbuIVZIFaZ4KLC18itaeZau6l5vdPScvbFJC%2FkTEnAYOuGt4PenHgKDOrb2Ll8YJ8d7w1fTqU7NEeNBMpjWn9YYAgOXPHgbQyvOmV%2BzjYQsszZpsucxPfQ%3D%3D--8fTdjl07SMTN5Oma--wCxW4dOIX2Gp864P%2FU2J%2FA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.772756389.1753304728; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:05:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:05:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8F3E:394F4C:10D500A:1409B1D:68814E98
[SOT][3.13] split certain `LOAD_ATTR` in 3.13+ & replace `get_items` and `flatten_items` with`flatten_inner_vars`,while replacing special cases with inheritance & remove method_name attribute in MethodVariable by GoldenStain · Pull Request #70927 · PaddlePaddle/Paddle · GitHub
[SOT][3.13] split certain
[SOT][3.13] split certain
GoldenStain
changed the title
[SOT] split certain
[SOT] split certain Jan 21, 2025
SigureMo
changed the title
[SOT] split certain
[SOT][3.13] split certain Jan 21, 2025
GoldenStain
changed the title
[SOT][3.13] split certain
[SOT][3.13] split certain Jan 21, 2025
GoldenStain
changed the title
[SOT][3.13] split certain
[SOT][3.13] split certain Jan 22, 2025
GoldenStain
changed the title
[SOT][3.13] split certain
[SOT][3.13] split certain Jan 22, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][3.13] split certain LOAD_ATTR in 3.13+ & replace get_items and flatten_items withflatten_inner_vars,while replacing special cases with inheritance & remove method_name attribute in MethodVariable
#70927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 14 commits into
PaddlePaddle:develop
from
GoldenStain:clas-problem-solving
Jan 23, 2025
Merged
[SOT][3.13] split certain LOAD_ATTR in 3.13+ & replace get_items and flatten_items withflatten_inner_vars,while replacing special cases with inheritance & remove method_name attribute in MethodVariable
#70927
SigureMo
merged 14 commits into
PaddlePaddle:develop
from
GoldenStain:clas-problem-solving
Jan 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoldenStain
changed the title
LOAD_ATTR in 3.12+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_varsLOAD_ATTR in 3.12+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_vars,while replacing special cases with inheritance
SigureMo
changed the title
LOAD_ATTR in 3.12+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_vars,while replacing special cases with inheritanceLOAD_ATTR in 3.12+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_vars,while replacing special cases with inheritance
SigureMo
reviewed
Jan 21, 2025
python/paddle/jit/sot/opcode_translator/executor/variables/container.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/instruction_utils/instruction_utils.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/instruction_utils/instruction_utils.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/instruction_utils/instruction_utils.py
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/instruction_utils/instruction_utils.py
Outdated
Show resolved
Hide resolved
GoldenStain
changed the title
LOAD_ATTR in 3.12+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_vars,while replacing special cases with inheritanceLOAD_ATTR in 3.13+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_vars,while replacing special cases with inheritance
GoldenStain
changed the title
LOAD_ATTR in 3.13+ & replace get_items and flatten_items with get_inner_vars and flatten_inner_vars,while replacing special cases with inheritanceLOAD_ATTR in 3.13+ & replace get_items and flatten_items withflatten_inner_vars,while replacing special cases with inheritance
SigureMo
reviewed
Jan 22, 2025
python/paddle/jit/sot/opcode_translator/executor/variables/basic.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/executor/variables/iter.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/executor/variables/iter.py
Outdated
Show resolved
Hide resolved
GoldenStain
changed the title
LOAD_ATTR in 3.13+ & replace get_items and flatten_items withflatten_inner_vars,while replacing special cases with inheritanceLOAD_ATTR in 3.13+ & replace get_items and flatten_items withflatten_inner_vars,while replacing special cases with inheritance & remove method_name attribute in MethodVariable
SigureMo
reviewed
Jan 22, 2025
python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py
Outdated
Show resolved
Hide resolved
问题 case 不应该只写在 PR 描述里，应该确保写在单测里，这样我们才能确保后续不会因为遇到相同问题造成回归，只要通过 CI 就能保证没有大问题 而如果 CI 检测不出来，合入之后的天级别、周级别 CE 才检测出来的话，反馈周期长，且会在 develop 影响大量下游场景，在修复完成前都会影响相关模型监控以及相关同学的开发，无论是对于自己负责的模块还是下游模块都会有影响 另一方面，相关 case 写在 CI 里我们才能放心进行代码重构，CI 过了就能拦截 90% 的问题，但如果 CI 单测体系不完备的话，今天刚修的 bug，过几个月再重构代码基本就忘掉了（团队开发更是如此），那没有单测覆盖到的逻辑就可能因此漏掉，后续还要再修一遍，浪费大量人力 这个 case 写在 |
SigureMo
reviewed
Jan 22, 2025
SigureMo
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
修复Bug
问题case:
在
MIN_GRAPH_SIZE超过该子图size的时候，连续两次执行forward函数会出现缺少位置参数的错误。在test/sot/test_min_graph_size.py中添加了针对此问题的新测试
test_layer_multiple_times原因
我们生成的字节码中，
LOAD_ATTR的最低位是1，交给python执行的时候，在第二次执行时，将原本load一个method+NULL的行为改为了load一个function+NULL，导致函数执行时找不到self.bug fix
在3.13+中，手动把最低一位为1的
LOAD_ATTR拆分为LOAD_ATTR+PUSH_NULL的组合经过确认，虽然3.12就引入了通过最低位来标志
LOAD_ATTR执行路径的方式，但是3.12不会出现该问题。get_items&flatten_items->flatten_inner_vars规范接口名称，并且把原来的特判改成了继承。
PCard-66972