| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 10:45:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=268.912171,conversation_content-fragment;desc="conversation_content fragment";dur=950.686801,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=327.713648,nginx;desc="NGINX";dur=0.896891,glb;desc="GLB";dur=101.480003
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MA%2BDwZqvfdGBspdDhFuPc29wFiOEk29J%2Fr6HYeonrZhrAiVIv9JsNrOG5GvEVAMsU7eU1f85ANOwB3w3EzAY0bpXAfkKXhzmy2u5pik2vlX0XqgS8ym9XSbdULrER9Sz6hBfvFrJ3QHsXmUwusrF2tEsxB3YTUrzXJhMMh%2FBLzSmpBYSZmr3C5AX%2BtIJikvWWxwEb2FYckOFZJDY5XMOuxO8PgxfRc3h1se20PlRewxe9EkvZhHh7BZmy%2Fbonsb%2BItO12XGyjKqlafzA%2F8jvcg%3D%3D--22SZqufWGkinuybb--Ak1Xn2yCdLEkBx6uLOZisQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.343869325.1753613102; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:45:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:45:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AAEE:37D5F1:D42357:118B31D:6886032E
[PIR-Auto-Parallel] set `op_role` and `chunk_id` for fuse linear pass by waliwali777 · Pull Request #70889 · PaddlePaddle/Paddle · GitHub
[PIR-Auto-Parallel] set
[PIR-Auto-Parallel] set
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR-Auto-Parallel] set op_role and chunk_id for fuse linear pass
#70889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
liym27
merged 8 commits into
PaddlePaddle:develop
from
waliwali777:move_fuse_linear_pass
Jan 26, 2025
Merged
[PIR-Auto-Parallel] set op_role and chunk_id for fuse linear pass
#70889
liym27
merged 8 commits into
PaddlePaddle:develop
from
waliwali777:move_fuse_linear_pass
Jan 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfncg
reviewed
Jan 20, 2025
Comment on lines
49
to
56
| } | ||
| if (add = user_it->owner()->dyn_cast<paddle::dialect::AddOp>()) { | ||
| if (add->operand_source(0) != tmp) { | ||
| continue; | ||
| } | ||
| can_fuse = true; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里没有限制matmul的输出只被add使用，替换fuse_gemm_epilogue的时候有失败的风险
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Comment on lines
-45
to
-46
| return (w_dims.size() == 2 && x_dims.size() >= 2 && | ||
| bias_dims.size() == 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w,x,bias的限制约束条件最好和原来保持一致
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
liym27
reviewed
Jan 21, 2025
| ): | ||
| pm = pir.PassManager() | ||
| pm.add_pass("fused_gemm_epilogue_pass", {}) | ||
| pm.run(dense_program) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里执行过 fused_gemm_epilogue_pass 后，是不是可以从 fused_passes_list 删掉了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| // fused to | ||
| // %4, %5 = pd_op.fused_gemm_epilogue( %0, %1, %3 ) | ||
| class FusedLinearPattern | ||
| : public pir::OpRewritePattern<paddle::dialect::MatmulOp> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么不用 DrrPattern 了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fuse pass 转移到 PP 和 gradient merge 之前进行调用，需要保证 fuse 后新算子的 op_role 和 chunk_id 与原来一致
DrrPattern 不支持获取和设置 op_role 和 chunk_id，所以采用较为底层的 PatternRewrite 接口实现
liym27
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Auto Parallel
PR Types
Improvements
Description
背景：在
PP并行 或者gradient merge策略下，PIR program 会被切分成forward、backward和optimizer子图，同时插入shawdow_output算子进行子图间数据传输，这可能会插在 fuse linear pattern 中，造成子图中 pattern 识别失败，使得 fuse linear pass 不能生效该 PR 将 fuse linear pass 转移到
PP并行 和gradient merge策略之前进行调用，但融合的fused_gemm_epilogue算子会丢失op_role和chunk_id的属性，在 pass 中增加op_role和chunk_id的属性设置，保证pp和gradient merge正常执行PCard-89139