| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:01:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=311.348444,conversation_content-fragment;desc="conversation_content fragment";dur=517.972184,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=425.331435,nginx;desc="NGINX";dur=1.53262,glb;desc="GLB";dur=101.073654
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=7AeUWLfwiUpOiFjewFnd%2BTo1vasLrUufzGVgxkhtHPTtP50gAi0DErtD3%2B6cPF22BgMJkwFOTEIF4eUl%2Fa1X3qF%2BsmTxjkAlN6pJ1pIR7ylFmTV5tDkpGobf2o39hYf3YVJrhs8JJo2NehNEismBYhO%2B3sMFaGaUOJT1pjNKySpoFUEw9O9SaaFQvL%2B8xtrRxHlWcNztTlFcSAx2EuokuQWBLPAkJ7WpUWmwu%2Bmg1aQyUKC4JoiJVY1IdSbb7W%2BIw3j3wUmnlcMBoUVqdnDVwA%3D%3D--MG2jo6E354Y5Fhj4--7As9mJTJA1hThr5LyB9RhQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1104200320.1753304484; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D7DA:256CA9:10BB376:13EDA29:68814DA4
[XPU] fix dense tensor usage in adam by houj04 · Pull Request #70856 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[XPU] fix dense tensor usage in adam #70856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QingshuChen
merged 1 commit into
PaddlePaddle:develop
from
houj04:20250116-fix-adam-temp-tensor
Jan 17, 2025
Merged
[XPU] fix dense tensor usage in adam #70856
QingshuChen
merged 1 commit into
PaddlePaddle:develop
from
houj04:20250116-fix-adam-temp-tensor
Jan 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqulilujia
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for image release
fangfangssj
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM |
LielinJiang
approved these changes
Jan 17, 2025
QingshuChen
approved these changes
Jan 17, 2025
|
你的PR提交成功，感谢你对开源项目的贡献! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Custom Device
PR Types
Bug fixes
Description
接到用户反馈说
adam算子在某些情况下计算结果不正确，排查的时候受到了这个PR #70847 的启发，发现beta1_pow和beta2_pow放在CPU上的时候会出错，而在XPU上的时候就没事。排查发现是有一个临时变量的使用不当，原版生成了临时的
DenseTensor之后给它赋值然后取了指针，随后这个临时变量被销毁，进而设备上的指针失效，但是在原版的后续代码中仍然使用了它。本PR修复了此问题，调整了两个临时变量的位置，改变了它们的生命周期。
这个优化器的代码实现较久，不确定是否还有别的问题，本PR先把这处明显有问题的给修掉。