| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:46:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=294.972826,conversation_content-fragment;desc="conversation_content fragment";dur=845.249034,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=360.083985,nginx;desc="NGINX";dur=0.807556,glb;desc="GLB";dur=100.638645
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kpym77EmOSUj1nEBOQozwxD9JoqIrWgpxgZE8CP75QnNKzmIK4zaUVjld4lIrCvEFWr1e4TQehMXohpfiAUi6cG7VMGrxYvrMSUdZa%2B9Hpplu%2FeTA7UOPI%2B%2F8FPUR2A6njajk8Y6Fsr4F8SlHvMpzekYbZXIOQDrXSUSn9nJIpwL2BDK5z6dnmkkJNGjWm%2FG9%2BrXS661GCMO4HkUzVvQNrgBZ0Xwkfjm0x%2F8vGkMioaokfLB5tUWaHOiWGpDSxhAWJ%2BDimWWTuLcIPLtI4u61w%3D%3D--2UYIv5VWXOZ%2Bop6L--aeSdfrNhiofapVFnlPH8mg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1948454130.1753400760; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A6EE:3FCB1:1E022:2ED95:6882C5B8
[AutoParallel] Fit pp and vpp for local layer by AndSonder · Pull Request #70831 · PaddlePaddle/Paddle · GitHub
AndSonder
requested review from
xiaoguoguo626807 and
changeyoung98
as code owners
January 14, 2025 11:07
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[AutoParallel] Fit pp and vpp for local layer #70831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
From00
merged 29 commits into
PaddlePaddle:develop
from
AndSonder:fit_vpp_for_local_layer
Jan 20, 2025
Merged
[AutoParallel] Fit pp and vpp for local layer #70831
From00
merged 29 commits into
PaddlePaddle:develop
from
AndSonder:fit_vpp_for_local_layer
Jan 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add_local_layer
… add_local_layer
…into add_local_layer
AndSonder
requested review from
xiaoguoguo626807 and
changeyoung98
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
… fit_vpp_for_local_layer
… fit_vpp_for_local_layer
From00
reviewed
Jan 20, 2025
| @@ -165,8 +165,14 @@ void ProcessDistBlock(pir::Block* block) { | |||
|
|
|||
| int64_t chunk_id = -1; | |||
| if (op_item->HasAttribute(kAttrOpDistAttr)) { | |||
| chunk_id = op_item->attribute<OperationDistAttribute>(kAttrOpDistAttr) | |||
| .chunk_id(); | |||
| if (op_item->HasAttribute("chunk_id")) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么会有两个地方存在chunk_id？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么会有两个地方存在
chunk_id？
之前的设计里面 chunk_id 是先存在 dist_attr 里面然后在 dist2dense 的时候再转存到 op 的属性中，但是像 local view 视角下的 op 就没有分布式属性，就只能直接存在 op 的属性里面。这个也是当时设计的时候没有考虑全面的地方，当时参考 programir 下的做法存放在 dist_attr 里面了，但是后续没有分布式属性的 op 是越来越多了，引入 local view 之后更好的做法是把 chunk_id 不存放在 dist_attr 里面，直接存在 op 的属性中，但是涉及到的代码的会非常多，这个 pr 先保证 local view 视角在 vpp 场景下可以跑起来
From00
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Auto Parallel
PR Types
Others
Description
Fit pp and vpp for local layer
Pcard-76459