| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:10:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=289.908845,conversation_content-fragment;desc="conversation_content fragment";dur=1038.309223,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=317.221471,nginx;desc="NGINX";dur=1.190508,glb;desc="GLB";dur=102.423395
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BmyK54iFjzn93r%2FqSvTYeMldhT92LcUnhFXiRcKOquh0iyXSIgoWleieVX4U4vYWwGF4y0U3MC0RLUOlO7oEMpr4Om9Zqd6waA3f8%2BFtckbpk%2BTvYewBC0Q1ubj9tK8Ao6aR4HVrH%2FJyFs5fVcrNmAzn2euqVt6gyQTh2pAU%2BTOoQIGAI9LenECzHoYvs%2BxPXZtIiw5X3WfJWN0nze42BKgcf4qY1EX7SbuOmvwQLjnapVx%2BBTNTHt7TMw4FsyZ8ct%2FlW6u0U6s0Phrm3%2FxxmA%3D%3D--WVOgIIhbawskyLLE--P2DwofibipZsoRxtqWw5ng%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.250968824.1753304999; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:09:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:09:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E382:35EBF4:10D2CC3:1409D65:68814FA7
[CINN][Backend Pass Update No.2] Update eliminate_common_global_memory_read pass by Albresky · Pull Request #70696 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN][Backend Pass Update No.2] Update eliminate_common_global_memory_read pass #70696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hongqing-work
merged 6 commits into
PaddlePaddle:develop
from
Albresky:cinn-pass-eliminate_common_global_memory_read
Jan 12, 2025
Merged
[CINN][Backend Pass Update No.2] Update eliminate_common_global_memory_read pass #70696
Hongqing-work
merged 6 commits into
PaddlePaddle:develop
from
Albresky:cinn-pass-eliminate_common_global_memory_read
Jan 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
| if (optim::ArithSimplify(ir::Sub::Make(lhs_extent, rhs_extent)) == | ||
| if (cinn::common::AutoSimplify(ir::Sub::Make(lhs_extent, rhs_extent)) == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不需要修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的，这里应该是最近的一个PR改成了ArithSimplify
Comment on lines
168
to
177
| buffer_size = optim::ArithSimplify(ir::Mul::Make( | ||
| buffer_size = cinn::common::AutoSimplify(ir::Mul::Make( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
Comment on lines
184
to
193
| size = optim::ArithSimplify(ir::Add::Make(size, buffer_size)); | ||
| size = cinn::common::AutoSimplify(ir::Add::Make(size, buffer_size)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
Comment on lines
241
to
-240
| } | ||
| ir::IRMutator<>::Visit(op, expr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里需要继续往内部遍历到body吧
|
这个Pass应该也是个全局Pass，可以参考#70619 |
好的 |
Comment on lines
408
to
419
| ir::stmt::Store new_body = | ||
| ir::stmt::_Store_::Make(new_tensor, | ||
| ir::ir_utils::IRCopy(ir::Expr(load_node)), | ||
| ir::ir_utils::IRCopy(load_node->indices)); | ||
| ir::stmt::BlockRef new_block = ir::stmt::_Block_::Make({new_body}); | ||
| ir::stmt::Schedule new_sch = | ||
| ir::stmt::_Schedule_::Make(sch_node->iter_vars(), | ||
| current_sch_->iter_values(), | ||
| {}, | ||
| {}, | ||
| sch_node->name() + "_local", | ||
| new_block); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里可以直接用Store/BlockRef/Schedule的带参数构造方法，不需要把这些带_的类再暴露出来了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
Comment on lines
377
to
379
|
|
||
| void VisitStmt(ir::stmt::Store stmt) override {} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
store为什么要截断不访问呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该是写一半忘记了
|
PR-CI-Coverage里面挂了很多子图，可以本地复现一下看看啥问题 |
Hongqing-work
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Improvements
Description
改造了 EliminateCommonGlobalMemoryRead pass