| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:27:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=378.244948,conversation_content-fragment;desc="conversation_content fragment";dur=1633.433924,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=380.255383,nginx;desc="NGINX";dur=1.099201,glb;desc="GLB";dur=101.417248
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=6BuhX5BRATYj84QU39aeiXPvk4KAblO24I8xYSGORQiog0kpBmI3WNfvl5ywl8%2FnrP%2FtGWkxu%2FvsINl8P7RVMcGS1kK9x04kltzjQCPGL02PhGCBG2hByze6GVY9OCbPd0lwufKuKn6BbRkUdm8GGz3jqd1N2D%2FTmTvrTLL4hlPLC1LGyK12%2FrjibJ5TyBo14NRft0J%2BRhUX%2FYi53mXCnEyKA4C4JKVvChbM0BbwMYFxYelDk3sL13nB%2Bm5ubBuBlAnKYZWSDpMvutFTIb57%2BQ%3D%3D--fBzi82K3aBt7MS0g--6kPsITV1xajvmHpSMu4rLQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1071601186.1753331235; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:27:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:27:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A170:36F97A:12F3844:1709E44:6881B623
[CINN] Add InferSymbolicShapeInterface for pd_op.strided_slice by ooooo-create · Pull Request #70541 · PaddlePaddle/Paddle · GitHub
ooooo-create
changed the title
[CINN] strided_slice
[CINN] Add InferSymbolicShapeInterface for pd_op.strided_slice
Feb 24, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN] Add InferSymbolicShapeInterface for pd_op.strided_slice #70541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CINN-shapeinfer-7
… CINN-shapeinfer-7
This reverts commit 6374d3c.
… CINN-stride_slice
… CINN-stride_slice
|
你的PR提交成功，感谢你对开源项目的贡献! |
| true, | ||
| common::errors::InvalidArgument( | ||
| "The size of axes must equal size of starts, ends, and strides.")); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
计算 out_dim 之前的stride、start、end的处理不太好跟 0-size 相关的逻辑对齐
| {symbol::Max<symbol::DimExpr>({unnegativate_lists})}); | ||
| } | ||
| } else { | ||
| out_dim = infer_context->GetNextSymName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start、end如果是符号的话，没法统一正负，上面的计算公式的正确性能保障吗？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不能保证正确，如果 start 是 -20，ends 是 -10，in_dim 是 10，或者 50 结果都不一样
|
Sorry to inform you that 9f63f17's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
| } else if (start_positive_end_negative) { | ||
| starts.at(i) = starts.at(i) - in_dims.at(axis); | ||
| } else { | ||
| PADDLE_THROW(common::errors::Fatal("Dead code")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
优化下报错信息
test/legacy_test/test_slice_op.py
Outdated
Comment on lines
144
to
154
| # 0-size test case | ||
| # class TestCase7(TestSliceOp): | ||
| # def config(self): | ||
| # self.input = np.random.random([3, 4, 5, 6]).astype("float64") | ||
| # self.starts = [-5] | ||
| # self.ends = [-5] | ||
| # self.axes = [1] | ||
| # self.infer_flags = [1, 1, 1] | ||
| # self.out = self.input[:, -5:-5, :, :] | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
清理单测
|
|
||
| def test_check_grad_normal(self): | ||
| self.check_grad( | ||
| ['Input'], 'Out', max_relative_error=0.006, check_pir=True | ||
| ) | ||
|
|
||
|
|
||
| # Test python API | ||
| class TestStridedSliceAPI(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python API 存在报错，负责同学修复前暂时注释
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其余单测本地已通过
gongshaotian
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ooooo-create
changed the title
zyfncg
approved these changes
Mar 3, 2025
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
…ePaddle#70541) * Enhance strided_slice operation with infer_flags and decrease_axis parameters * fix * fix * fix * fix * fix * fix * Revert "fix" This reverts commit 6374d3c. * fix * fix * fix bugs * fix bugs * fix bugs * add tests * refine code * refine code * refine code * refine code * refine code * fix bugs --------- Co-authored-by: PuQing <me@puqing.work>
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
…ePaddle#70541) * Enhance strided_slice operation with infer_flags and decrease_axis parameters * fix * fix * fix * fix * fix * fix * Revert "fix" This reverts commit 6374d3c. * fix * fix * fix bugs * fix bugs * fix bugs * add tests * refine code * refine code * refine code * refine code * refine code * fix bugs --------- Co-authored-by: PuQing <me@puqing.work>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Others
Description
Pcard-67164