| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:21:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=297.270822,conversation_content-fragment;desc="conversation_content fragment";dur=987.934669,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=471.971501,nginx;desc="NGINX";dur=1.224598,glb;desc="GLB";dur=102.370489
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Bhi8Lp03etVqhM1ZuY%2BORxdKhzsagWh2dUJJZ%2BJ26tZIFn76vxPc7T0cWWhqDXCVv9B88Rt7VCXGU9ClM28kzGTpEAgxQK6%2BrNOLDhOsrQ6lpKJMQO2SF0H9yTWcRqPUifpyee550mxvSZZBLDKQX7uiT7E14VhKTHagY7WV%2Ffl9MESLOidMidWgBV%2BsJFUH247U8G1EzPyEKLo3ANjGimJTlyA4N5esmyddhsEUBu1qpqzfWlx3ljCVifB7VL%2BuaLJZsaXZDHac9e12TnRgyg%3D%3D--KIUDBAXzZxWcBa3%2F--Hb%2FYstjSGzRe7ZsdVgFAVw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1682529267.1753330860; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:21:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:21:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9640:256CA9:12CA0D3:16DD084:6881B4AC
[SOT][DynamicShape] Fix `SymbolicVariable` `get_py_value` reversed call and break graph on infermeta encount `TypeError` by SigureMo · Pull Request #70009 · PaddlePaddle/Paddle · GitHub
[SOT][DynamicShape] Fix
SigureMo
changed the title
[SOT][DynamicShape] Enable
[SOT][DynamicShape][3.13] Enable Dec 6, 2024
SigureMo
changed the title
[SOT][DynamicShape][3.13] Enable
[SOT][DynamicShape][3.13] Fix Dec 9, 2024
SigureMo
changed the title
[SOT][DynamicShape][3.13] Fix
[SOT][DynamicShape] Fix Dec 9, 2024
SigureMo
deleted the
sot/enable-break-graph-on-get-symbolic-value-and-break-graph-on-infermeta-encount-type-error
branch
December 9, 2024 16:14
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][DynamicShape] Fix SymbolicVariable get_py_value reversed call and break graph on infermeta encount TypeError
#70009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 6 commits into
PaddlePaddle:develop
from
cattidea:sot/enable-break-graph-on-get-symbolic-value-and-break-graph-on-infermeta-encount-type-error
Dec 9, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d break graph on infermeta encount `TypeError`
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
SOT_BREAK_GRAPH_ON_GET_SYMBOLIC_VALUE and break graph on infermeta encount TypeErrorSOT_BREAK_GRAPH_ON_GET_SYMBOLIC_VALUE and break graph on infermeta encount TypeError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (2)
python/paddle/jit/sot/opcode_translator/executor/function_graph.py:666
- The word 'encount' should be 'encounter'.
raise BreakGraphError(f"InferMeta encount {type(e)}, but all args are not symbolic.")
python/paddle/jit/sot/opcode_translator/executor/function_graph.py:693
- The word 'encount' should be 'encounter'.
raise BreakGraphError(f"InferMeta encount {type(e)}, but all args are not symbolic.")
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gouzil
previously approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (2)
python/paddle/jit/sot/opcode_translator/executor/function_graph.py:666
- The error message contains a typo: 'encount'. It should be 'encountered'.
raise BreakGraphError(f"InferMeta encount {type(e)}, but all args are not symbolic.")
python/paddle/jit/sot/opcode_translator/executor/function_graph.py:693
- The error message contains a typo: 'encount'. It should be 'encountered'.
raise BreakGraphError(f"InferMeta encount {type(e)}, but all args are not symbolic.")
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gouzil
reviewed
Dec 6, 2024
Co-authored-by: gouzil <66515297+gouzil@users.noreply.github.com>
zrr1999
approved these changes
Dec 6, 2024
zrr1999
previously approved these changes
Dec 8, 2024
SigureMo
changed the title
SOT_BREAK_GRAPH_ON_GET_SYMBOLIC_VALUE and break graph on infermeta encount TypeErrorSymbolicVariable get_py_value reversed call and break graph on infermeta encount TypeError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
python/paddle/jit/sot/opcode_translator/executor/variables/basic.py:109
- The function 'method_to_reverse_method' is not covered by any tests. Please add a test case to ensure its correctness.
def method_to_reverse_method(method_name: str) -> str | None:
zrr1999
approved these changes
Dec 9, 2024
SigureMo
changed the title
SymbolicVariable get_py_value reversed call and break graph on infermeta encount TypeErrorSymbolicVariable get_py_value reversed call and break graph on infermeta encount TypeError
SigureMo
deleted the
sot/enable-break-graph-on-get-symbolic-value-and-break-graph-on-infermeta-encount-type-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
目前 Fallback 回静态 shape 的策略有点 bug，比如
SymbolicVariable(10) * SymbolicVariable(0.25)的结果的 Tracker 里的 method 是__mul__，但实际上触发的是float.__rmul__，而这里按照记录的__mul__计算的结果是(10).__mul__(0.25) = NotImplemented，导致后续挂掉因此将暂时通过转为SOT_BREAK_GRAPH_ON_GET_SYMBOLIC_VALUE开启默认，直接打断，不走 Fallback 回静态 shape，预期可能有部分模型有性能下降，但正确性优先__rmul__解决，之后需要寻找一个更好的方案另外就是有些 API 动静不统一，比如
randperm的第一个参数n，输入是 int，动态图下 API 可以将 Tensor cast 为 int，但动转静后传入 Value 是会挂的，因此如果遇到TypeError直接 BreakGraph 确保正确性PCard-66972