| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 02:28:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=265.994496,conversation_content-fragment;desc="conversation_content fragment";dur=928.583753,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=364.153425,nginx;desc="NGINX";dur=1.058912,glb;desc="GLB";dur=100.89599
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=u08UKxUxI44oSayuDRDB5KNe6aj73Z0KbqhNyOlo43LqfvcutzjKIUSfndksk2OzTTU3kK7h%2BLMatRku5fbwBKoeoB9UvKDy9wLCydxsvjJs0oztC1SZolQuRyBhO%2F0MDaQUGSlU5eGiq8Wk7QcQDOly4PxmS84mkKHLl6UXK7WMukR7LFzZ3aXCrFfkBpCuBRg%2FohlvApCyeD4UW8QgO594GOEY9db%2BZ2e%2FFhWqr5zVL9GMv66gSY%2FlVVaDni%2BivH10DYr0R%2FFqR6D%2BmYr4SQ%3D%3D--jqJM105djxgv8zoj--bsysxqmoBCHm5AYbHSB6xg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.525228142.1753496889; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:28:09 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:28:09 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 827C:3240E6:C4CC1:1365EC:68843D39
[SOT][Faster Guard] add `InstanceCheckGuard` by gouzil · Pull Request #69975 · PaddlePaddle/Paddle · GitHub
[SOT][Faster Guard] add
[SOT][Faster Guard] add
gouzil
requested review from
Copilot
and removed request for
SigureMo and
zrr1999
December 5, 2024 07:38
SigureMo
changed the title
[WIP][SOT][Faster Guard] add
[SOT][Faster Guard] add Dec 11, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][Faster Guard] add InstanceCheckGuard
#69975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
gouzil:sot/faster_guard_ContainerVariable
Dec 11, 2024
Merged
[SOT][Faster Guard] add InstanceCheckGuard
#69975
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
gouzil:sot/faster_guard_ContainerVariable
Dec 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouzil
requested review from
Copilot
and removed request for
SigureMo and
zrr1999
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 27 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- paddle/fluid/pybind/jit.cc: Language not supported
- paddle/fluid/pybind/sot/guards.cc: Language not supported
- paddle/fluid/pybind/sot/guards.h: Language not supported
- python/paddle/jit/sot/opcode_translator/executor/variables/container.py: Evaluated as low risk
- test/sot/test_enumerate.py: Evaluated as low risk
- test/sot/test_builtin_map.py: Evaluated as low risk
- test/sot/test_builtin_dispatch.py: Evaluated as low risk
- test/sot/test_builtin_range.py: Evaluated as low risk
- test/sot/test_dtype.py: Evaluated as low risk
- test/sot/test_04_list.py: Evaluated as low risk
- test/sot/test_12_for_loop.py: Evaluated as low risk
- test/sot/test_builtin_bool.py: Evaluated as low risk
- test/sot/test_05_dict.py: Evaluated as low risk
- test/sot/test_21_global.py: Evaluated as low risk
- test/sot/test_15_slice.py: Evaluated as low risk
Comments skipped due to low confidence (1)
python/paddle/jit/sot/opcode_translator/executor/variables/basic.py:1047
- The string should be "id(type({{}})) == id(type(slice))" to correctly match the type.
FasterStringifiedExpression("id(type({{}}) == id(type(slice))", paddle.framework.core.TypeMatchGuard(slice), [frame_value_tracer], frame_value_tracer.free_vars,)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 27 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- paddle/fluid/pybind/jit.cc: Language not supported
- paddle/fluid/pybind/sot/guards.cc: Language not supported
- paddle/fluid/pybind/sot/guards.h: Language not supported
- test/sot/test_18_tensor_method.py: Evaluated as low risk
- test/sot/test_04_list.py: Evaluated as low risk
- test/sot/test_12_for_loop.py: Evaluated as low risk
- test/sot/test_21_global.py: Evaluated as low risk
- test/sot/test_15_slice.py: Evaluated as low risk
- test/sot/test_dtype.py: Evaluated as low risk
- test/sot/test_builtin_dispatch.py: Evaluated as low risk
- test/sot/test_05_dict.py: Evaluated as low risk
- test/sot/test_builtin_map.py: Evaluated as low risk
- test/sot/test_builtin_bool.py: Evaluated as low risk
- test/sot/test_14_operators.py: Evaluated as low risk
- test/sot/test_07_unpack.py: Evaluated as low risk
python/paddle/jit/sot/opcode_translator/executor/variables/basic.py
Outdated
Show resolved
Hide resolved
…ic.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ard_ContainerVariable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 19 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- paddle/fluid/pybind/jit.cc: Language not supported
- paddle/fluid/pybind/sot/guards.cc: Language not supported
- paddle/fluid/pybind/sot/guards.h: Language not supported
- python/paddle/jit/sot/opcode_translator/executor/variables/container.py: Evaluated as low risk
- test/sot/test_05_dict.py: Evaluated as low risk
- test/sot/test_side_effects.py: Evaluated as low risk
- test/sot/test_dtype.py: Evaluated as low risk
- test/sot/test_builtin_dispatch.py: Evaluated as low risk
- test/sot/test_04_list.py: Evaluated as low risk
- test/sot/test_12_for_loop.py: Evaluated as low risk
- test/sot/test_builtin_bool.py: Evaluated as low risk
- test/sot/test_builtin_map.py: Evaluated as low risk
- test/sot/test_15_slice.py: Evaluated as low risk
- test/sot/test_14_operators.py: Evaluated as low risk
zrr1999
approved these changes
Dec 10, 2024
SigureMo
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: test_with_faster_guard 可以考虑改成不是单测端到端跑两遍，而是生成两份 guard（faster 和非 faster），并且在运行 guard 时候比较两者，确保两者完全一致
这样一方面节省了测试成本，另一方面测试也会更加完备些（端到端测试大多数 case 是没有检查 cache 是否命中的）
LGTMeow
| frame_value_tracer.free_vars, | ||
| ) | ||
| len_guard = StringifiedExpression( | ||
| if self.get_py_type() is dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: 后续考虑一种更好的方式来消除 if
SigureMo
changed the title
InstanceCheckGuardInstanceCheckGuard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
InstanceCheckGuardContainerVariableTODO
test_sot_resnet.py会出现TypeError: collections.OrderedDict is not a sequencetest_sot_export.pyassert 文件不存在（尝试用了test_instruction_translator_cache_context还是不行）InstanceCheckGuard暂时不支持isinstance(1, (int, bool))的情况