| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:26:31 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=259.316639,conversation_content-fragment;desc="conversation_content fragment";dur=1100.466731,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=311.059615,nginx;desc="NGINX";dur=1.65571,glb;desc="GLB";dur=100.852597
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YA24JClDj5nOiLf2R1p1qcaSvYJ5%2BwNohzGzhFn4i4TrRqt9bB%2FIYVzJn%2BHNBIiJodnM1bHVCoDTmmeXj7ubWPTK3BqlkZcN4vS1lGauOxxkZemTpEvVHJtgM31ST%2BG1xiHr%2FYJmwcMrKOzHpUEMPyjLvng0N2pd8rKaij9jE8Jv24An19OPDKTJzRjzCDFZq29cLs1DJErC147JlyuNflxRvp8y8%2BRfqmqbcdYGhd5zRstwg%2Bprj75ORyvss%2F%2BXeP63XHelHhLG%2BvLOEb7iag%3D%3D--jS661iLxe6aKGoTT--RLaJ%2Fpc9SkFYTtpTmT37vg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.52426971.1753331189; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:26:29 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:26:29 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EDEA:36F97A:12F16C9:17076EA:6881B5F5
【Infer Symbolic Shape No.232】Add infer_symbol_shape for StridedSlice by AndPuQing · Pull Request #69911 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Infer Symbolic Shape No.232】Add infer_symbol_shape for StridedSlice #69911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Dec 3, 2024
| ExprVec ends = slice_utils::GetExprVecFromData(ends_shape_data); | ||
| ExprVec strides = slice_utils::GetExprVecFromData(strides_shape_data); | ||
|
|
||
| std::vector<int64_t> axes_vec = details::GetVectorAttr(op, "axes"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以先尝试添加一个 Int32 的特化模版
Hongqing-work
approved these changes
Dec 4, 2024
|
规范下 Description |
|
TestStridedSliceAPI 和 TestStridedSliceTensorArray 的单测问题交由 @kevincheng2 修复 |
zyfncg
approved these changes
Dec 4, 2024
| return slice_dims; | ||
| } | ||
|
|
||
| inline ShapeOrData StridedSliceRawInferSymbolicShape( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StridedSliceRawInferSymbolicShape这个函数为什么放到infer_sym_slice_utils.h文件中？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SliceRawInferSymbolicShape 也放在utils.h里了，放一起容易维护
gongshaotian
reviewed
Dec 4, 2024
| symbol::TensorShapeOrDataDimExprs(out_dims)}; | ||
| }; | ||
|
|
||
| // When `pd.slice` is operating on a tensor which is produced by a `pd.shape` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该是 strided_slice 吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以放下个PR修改
gongshaotian
reviewed
Dec 4, 2024
Comment on lines
+3506
to
+3507
| std::vector<int64_t>{}, | ||
| std::vector<int64_t>{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确认一下，infer_flags_raw 和 decrease_axis 默认都是空有问题吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是因为
stride_slice并未注册这两个参数，导致无法通过GetVectorAttr得到的StridedSliceRawInferSymbolicShape复用了slice的GetDecreasedDims所以对decrease_axis这里构造了空向量，而infer_flags这个参数是一个无效参数，在slice和stride_slice均没有用到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
|
原PR：#69290 |
|
APPROVAL 流水线发现了一些报错信息规范的问题，可以与注释一起提pr修改，连带检查下slice的几个工具函数里是不是报错信息也不规范 |
gongshaotian
approved these changes
Dec 4, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
TestStridedSliceAPI和TestStridedSliceTensorArray无法通过starts、ends和strides为Inputs的单测因无法在运行前得到，所以禁用