| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:01:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=261.329951,conversation_content-fragment;desc="conversation_content fragment";dur=1103.731962,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=421.788081,nginx;desc="NGINX";dur=1.351385,glb;desc="GLB";dur=101.140503
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1%2FrZ5jveQOp5ziXFmZj5ru3xqkPR8bOwMsXzYPkxsIxOksVsAersKBTNAqBPvep9ID%2ByksNiZmnsqqUArHwwQ7lUUgkQEcW4pjOX%2FEqILHyqcbzqvtRyqT9BOB1ps5DxRef0bmpcFISye%2FNzsYV62n60XM31m0pizALjt3uSCH9Dr%2B%2BFrEPgGFttk1uxuqbFZK69b8GZ7O1ZlaCPwYBX7PgkHWc%2BFA%2FOUA5jWzf2CNkEpWRP%2F1Pe9P5Kbu2PNmq31BC5KbrQWYK3VYOEsjEmXw%3D%3D--YDq9wUuaqEZ0gfpe--rGRnT3OGxbZiOYAREJfm2Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1860604357.1753304492; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8BF8:3B93B0:10D7781:140A29F:68814DAC
[SOT] Add dispatch for `min/max(*args)` and add `paddle.geometric` to paddle API list by SigureMo · Pull Request #69746 · PaddlePaddle/Paddle · GitHub
[SOT] Add dispatch for
[SOT] Add dispatch for
SigureMo
changed the title
[SOT] Add dispatch for
[SOT][3.13] Add dispatch for Nov 27, 2024
SigureMo
changed the title
[SOT][3.13] Add dispatch for
[SOT] Add dispatch for Nov 27, 2024
SigureMo
deleted the
sot/add-dispatch-for-min-max-star-args-and-add-paddle-geometric-to-paddle-api-list
branch
November 27, 2024 14:37
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Add dispatch for min/max(*args) and add paddle.geometric to paddle API list
#69746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 4 commits into
PaddlePaddle:develop
from
cattidea:sot/add-dispatch-for-min-max-star-args-and-add-paddle-geometric-to-paddle-api-list
Nov 27, 2024
Merged
[SOT] Add dispatch for min/max(*args) and add paddle.geometric to paddle API list
#69746
SigureMo
merged 4 commits into
PaddlePaddle:develop
from
cattidea:sot/add-dispatch-for-min-max-star-args-and-add-paddle-geometric-to-paddle-api-list
Nov 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zrr1999
previously approved these changes
Nov 27, 2024
| @Dispatcher.register_decorator(max) | ||
| def dispatch_max_star_args(*args: VariableBase): | ||
| if not args: | ||
| raise TypeError("max expected 1 arguments, got 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| raise TypeError("max expected 1 arguments, got 0") | |
| raise TypeError("max expected at least 1 arguments, got 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我还以为 copilot 补全的是全的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 suggestions.
Comments skipped due to low confidence (1)
python/paddle/jit/sot/opcode_translator/executor/variables/container.py:413
- The error message should be 'min() arg is an empty sequence' instead of 'max() arg is an empty sequence'.
raise ValueError("min() arg is an empty sequence")
| @Dispatcher.register_decorator(max) | ||
| def dispatch_max_star_args(*args: VariableBase): | ||
| if not args: | ||
| raise TypeError("max expected 1 arguments, got 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message "max expected 1 arguments, got 0" is misleading because max can accept more than one argument. It should be "max expected at least 1 argument, got 0".
Suggested change
| raise TypeError("max expected 1 arguments, got 0") | |
| raise TypeError("max expected at least 1 argument, got 0") |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
| @Dispatcher.register_decorator(min) | ||
| def dispatch_min_star_args(*args: VariableBase): | ||
| if not args: | ||
| raise TypeError("min expected 1 arguments, got 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message "min expected 1 arguments, got 0" is misleading because min can accept more than one argument. It should be "min expected at least 1 argument, got 0".
Suggested change
| raise TypeError("min expected 1 arguments, got 0") | |
| raise TypeError("min expected at least 1 argument, got 0") |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
SigureMo
changed the title
min/max(*args) and add paddle.geometric to paddle API listmin/max(*args) and add paddle.geometric to paddle API list
zrr1999
approved these changes
Nov 27, 2024
SigureMo
changed the title
min/max(*args) and add paddle.geometric to paddle API listmin/max(*args) and add paddle.geometric to paddle API list
SigureMo
deleted the
sot/add-dispatch-for-min-max-star-args-and-add-paddle-geometric-to-paddle-api-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
min/max(*args)形式的 dispatch，避免打断paddle.geometric模块添加到组网模块，避免模拟到_C_ops层导致打断PCard-66972