| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CodeStyle][Typos][A-45] Fix typo (AVALIABLE)
#69652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
学一下分支管理，别从上一个 PR 的分支继续提 PR |
那这次的提交还要改吗 |
这次可以不改分支，但你得解决冲突啊 |
SigureMo
changed the title
SigureMo
changed the title
AVALIABLE)
SigureMo
changed the title
AVALIABLE)AVALIABLE)
_typos.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
自己看看 diff，冲突解决的不对
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的，我研究下
kanze1
force-pushed
the
fix_typo_available
branch
from
c98fc33 to
9434d7a
Compare
cmake/cuda.cmake
Outdated
| @@ -287,7 +287,7 @@ elseif(${CMAKE_CUDA_COMPILER_VERSION} LESS 13.0) # CUDA 12.0+ | |||
| endif() | |||
|
|
|||
| if(NOT ${CMAKE_CUDA_COMPILER_VERSION} LESS 10.0) | |||
| add_definitions("-DTRT_PLUGIN_FP16_AVALIABLE") | |||
| add_definitions("-DTRT_PLUGIN_FP16_available") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
人家原来是全大写的，你改成小写的不觉得有问题吗？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那怎么改呀？=-=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改成全大写啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
他原本就是全大写，我应该是只修复原本的那一个错误，然后关于大写的就不动，那之前合并的那次pr应该就可以了对吗？我修改描述说明这个宏定义的大写不需要修改是不是这个意思？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AVALIABLE -> AVAILABLE 怎么能是不动呢？这里是拼写错误又不是大小写错误
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
啊，我明白了，抱歉，犯蠢了
kanze1
force-pushed
the
fix_typo_available
branch
from
9434d7a to
048ea14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
PR Category
User Experience
PR Types
Bug fixes
Description
修复代码中的拼写错误并更新 _typos.toml：
修复 round_robin.h 中的拼写错误：
将注释中的 "AVALIABLE" 改为 "available"
更新 _typos.toml：
删除了已修复的 "AVALIABLE= 'AVALIABLE'" 条目