| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:20:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=256.298709,conversation_content-fragment;desc="conversation_content fragment";dur=1052.892537,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=332.956238,nginx;desc="NGINX";dur=1.298216,glb;desc="GLB";dur=101.556313
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=rivwpDIiyQcK7fY9lgcu6qUxFzStqVZNS54ujKqls9yOZCfA4d%2BOjcGB%2BVdu1YWcYBfMG5KreS7GqLJ2uBboldU35l9aEhVIlWK5d%2BzNj7gziHq69Jen76ZGEm2juLH4r8hzrl2ekiH5DDyRb5UtDwY4cDANBhmWG1K3PngilL9h0%2BBKd6GEsj5H4HXAkw1tof%2BrcSOyK40xS2Q36AuqZw%2BRZ4TUeGv4ZDNzQHNCy9%2B5Hz5IXmoKLPnJ0sEleqVNhyAevmXtPSMYtlcPV7dRXw%3D%3D--nO2YJOYUJBmcXk0v--G0mJH8jMWZlbq%2B3foumAjw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1903703820.1753330814; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:20:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:20:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9F46:18BEF9:305546:434BA7:6881B47E
[SOT][3.13] support `CONVERT_VALUE` and `FORMAT_WITH_SPEC` opcode in python3.13 by GoldenStain · Pull Request #69401 · PaddlePaddle/Paddle · GitHub
[SOT][3.13] support
GoldenStain
requested review from
SigureMo,
zrr1999 and
gouzil
as code owners
November 14, 2024 09:04
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][3.13] support CONVERT_VALUE and FORMAT_WITH_SPEC opcode in python3.13
#69401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoldenStain
requested review from
SigureMo,
zrr1999 and
gouzil
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 15, 2024
python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py
Outdated
Show resolved
Hide resolved
Closed
SigureMo
reviewed
Nov 17, 2024
test/sot/test_22_convert_string.py
Outdated
|
|
||
| def foo(x: paddle.Tensor): | ||
| float_num = 3.1415 | ||
| float_string = f"{float_num:.2f}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个测试 case 是否可以直接添加到 test_09_f_string 里？
测试名称可以改一下，不用 foo，这是最初设计单测时候随便起的
python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 suggestion.
| ) | ||
| if isinstance(value, ConstantVariable): | ||
| result = value.get_py_value() | ||
| result = getattr(result, convert_fn)(result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method retrieved using getattr should be called without passing result as an argument. It should be result = getattr(result, convert_fn)().
Suggested change
| result = getattr(result, convert_fn)(result) | |
| result = getattr(result, convert_fn)() |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个看起来挺合理，@GoldenStain 看看这样是否正确？
之前代码也是这样写的，有点怀疑之前是怎么跑的，需要确认下单测是否能跑到这个分支，以及 result 是什么，正常字符串应该会挂的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前的测试函数
def fstring_with_spec(x: paddle.Tensor):
float_num = 3.1415
float_string = f"{float_num:.2f}"
z = assert_true(float_string == "3.14")
x = x + 1
return x
只能触发FORMAT_WITH_SPEC
还不能触发CONVERT_VALUE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确实不能传入参数
File "/workspace/Paddle/test/sot/test_09_f_string.py", line 36, in fstring_with_convert_test
formatted_string = f"{obj!r}"
TypeError: expected 0 arguments, got 1
…ase about CONVERT_VALUE
SigureMo
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Performance Optimization
PR Types
Others
Description
支持了字节码
CONVERT_VALUE和FORMAT_WITH_SPEC,为test_09_f_string.py添加了对FORMAT_WITH_SPEC和CONVERT_VALUE的测试；完善了原先字节码
FORMAT_VALUE的format转换。