| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:06:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=223.427191,conversation_content-fragment;desc="conversation_content fragment";dur=839.242126,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=306.065886,nginx;desc="NGINX";dur=0.809938,glb;desc="GLB";dur=101.225907
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=G0VTbDludJpSBgl4rLXklMH8wf6MpDi6H2bebndr9k6ygVoZ9%2Ft7XVyi%2BUICB%2BbvCN4bhgHHBer%2FF%2FKLU0D0rHu6%2BJXo%2B1mtbMe8GPYx7o6CI0vth28cyFiczKLcoSW8mqKOafwoWzEjdtzl80R1a4ElqXxwba%2Bh1jVPjjNuddDTsYXYSBsDtC3o8x6v%2FvAPe6QZ%2FNeugq14q5lw6UsC%2Fh2RAbxd3VF8weoCSD0xx%2BktTm3qpzRulqG4334YOBfVkt8XV1OTvRKB14U50FEiPQ%3D%3D--M51k%2B2WCh63AP%2B8e--czKp39HvvMePnZxFwICcMw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.256599687.1753402015; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:06:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:06:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E3B4:11D253:2FCAB:4B57C:6882CA9F
【CINN】IndexExpr update by liuruyan · Pull Request #69282 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【CINN】IndexExpr update #69282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
【CINN】IndexExpr update #69282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Dec 10, 2024
|
|
||
| Type type() const { return source.type(); } | ||
| IndexExpr source; | ||
| Expr source; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些变量为什么换成了Expr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为抽象出IndexExpr之后，让IterExpr继承自Expr，所以source需要改为Expr，但是lower_factor和extent仍然为IndexExpr
paddle/cinn/common/ir_util.cc
Outdated
Comment on lines
812
to
813
| return SimplifySymbolicDivide(lhs->operand_as_index(0), sym, ty) + | ||
| SimplifySymbolicDivide(lhs->operand_as_index(1), sym, ty); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如何保证lhs->operand_as_index(0)在任何情况下都是work的？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
规定IndexExpr内部必须全部都是IndexExpr，不允许出现Expr。并且SimplifySymbolicDivide函数参数是IndexExpr，因此operand_as_index都是正确的，而不需is_index判断。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果都是IndexExpr，那是否可以 operand(i) 直接返回 IndexExpr 类型？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以，已在IndexExpr类内添加operand方法
zyfncg
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
IndexExpr不再继承自Expr，而是与Expr相同抽象级别Expr中添加IndexExpr的构造函数，且添加is_index()、as_index()、set_index()方法，IrNode中添加is_index_来唯一标识该节点是否为下标相关节点，添加get_index、set_index方法支持进行修改Expr ==运算符，当操作数均为IndexExpr时升格使用IndexExpr判等，重载
IndexExpr +-*/%运算符，运算时进行化简。（注：暂时未调整
Expr+-*/%，日后可以设置当操作数均为IndexExpr时进行化简操作）IRVisitorRequireReImpl，当Visit参数明确为IndexExpr*时停止（注：暂时参数为
Expr，但is_index_为true时仍然进行遍历）Pcard-67164