CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 21:01:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=346.65998,conversation_content-fragment;desc="conversation_content fragment";dur=750.572869,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=429.754963,nginx;desc="NGINX";dur=1.216841,glb;desc="GLB";dur=100.197921
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8th2W%2FGVz7coUgIxqC6U4XmdHpD8oDL8ZLIWQCybcuEE3Lw%2BujTpCy27odINIgy1ylPlqcrwgyZKa5LCT2FaJmuIXKnVW0ov%2B3cn4bG%2FT22YsdP5RzihX0pP3RKJOFAuEdc5%2BOvHE6BMqf%2BKzUXu%2ByvwKv2JnOi3o%2BEY2VgMaharlF4CZwBgKPJvCtPo4A%2FELP%2BNoHIq2rWmCgSZ%2FBiENFFV6SaA58a0%2BbM%2FWaQsY%2FH1rD%2BXka3zaF%2F04tmJRKOOAa%2FsxPNGoNHKu7t6IpxBhg%3D%3D--cTDv0VaESzCKOsWW--MYKBMHRVIyuRjcj3zlsckg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1590782810.1753304498; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 21:01:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8C22:D3350:10CD404:13FFFE8:68814DB2
[Dy2St][PIR] Allow expand `UndefinedVar` to multiple values in control flow by SigureMo · Pull Request #69210 · PaddlePaddle/Paddle · GitHub
[Dy2St][PIR] Allow expand
[Dy2St][PIR] Allow expand
SigureMo
changed the title
[Dy2St][PIR] Allow expand UndefinedVar to multiple values in control flow
[Dy2St][PIR] Allow expand Nov 6, 2024
SigureMo
deleted the
dy2st/allow-expand-undefined-var-to-multiple-values-in-control-flow
branch
November 8, 2024 02:45
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Dy2St][PIR] Allow expand UndefinedVar
to multiple values in control flow
#69210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
cattidea:dy2st/allow-expand-undefined-var-to-multiple-values-in-control-flow
Nov 8, 2024
Merged
[Dy2St][PIR] Allow expand UndefinedVar
to multiple values in control flow
#69210
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
cattidea:dy2st/allow-expand-undefined-var-to-multiple-values-in-control-flow
Nov 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
UndefinedVar
to multiple values in control flow
SigureMo
commented
Nov 8, 2024
@@ -679,6 +680,77 @@ def has_shape_diff(x_var, y_var): | |||
paddle.assign(input, output) | |||
|
|||
|
|||
def create_fake_value_for_undefined_var(while_op, value): | |||
# Create a fake value for create WhileOp, it's type will be reset after body is executed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里注释已经不准确了,之后 PR 清理下
gouzil
approved these changes
Nov 8, 2024
winter-wang
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
允许一个 UndefindVar 经过 loop body 之后变为多个 Value 的情况
比如对于如上 case,最开始
a
是一个UndefinedVar
,经过 loop body 后变成了[Value(), Value()]
,这会导致 while op 的输入输出不匹配,因为如果输入是UndefinedVar
我们会创建一个 FakeValue,而输出则是两个因此新的方案对控制流进行了重写,在
build_while_op
时不再提前创建 FakeValue,而是在跑完 loop body 后,根据输出来 infer 输入里的 UndefinedVar 的 type,此时才创建 FakeValue比如
UndefindVar()
->Value(type1)
,会将输入变为Value(type1)
UndefindVar()
->[Value(type1), Value(type2)]
,会将输入变为[Value(type1), Value(type2)]
新增的 FakeValue 会作为
PyWhileOp
的extra_inputs_
,会在OptimizeUpdate
的时候创建新的WhileOp
,以更新输入输出PCard-66972