| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:46:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=395.335968,conversation_content-fragment;desc="conversation_content fragment";dur=1243.591246,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=396.950397,nginx;desc="NGINX";dur=1.194832,glb;desc="GLB";dur=101.35179
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=H2O2fO222izTVnuHBCdw1oGMr8QbX0SDQ8jCBppbIZwfvONA4eboGeO7gdpBMUCorvfDimZcAPN4zTcMklH0%2BtaD5ByOP9y3DmEgV5hrHkyFvUJ8E82J6lC4%2FJ%2BDgyGOV2oR0FyfauKCPIDc6vDdoaWwWMSqA5vhJm7h7KnXHOWjNJ639sD%2B7usgJtAADH3TSdteIl0qMbfPW%2FMJrsYVx0%2BdUApNCI8N6fBeNjZhaPIsW2K7FMkHcUgZZVrxq%2F3U2mYtdiips2KQp0NZWsOTSA%3D%3D--n1i%2BC2X2UUB5ZHUp--9%2BrkHttKKZsfzzDwWFAJYw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1205144299.1753400798; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:46:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 97E8:69B36:1E9D1:2FC6B:6882C5DE
[SOT][3.13] add `LOAD_FAST_LOAD_FAST`、 `STORE_FAST_STORE_FAST`、 `STORE_FAST_LOAD_FAST` and add skip tests files by gouzil · Pull Request #69196 · PaddlePaddle/Paddle · GitHub
[SOT][3.13] add
SigureMo
changed the title
[SOT] add
[SOT][3.13][Typing] add Nov 6, 2024
gouzil
changed the title
[SOT][3.13][Typing] add
[SOT][3.13]add Nov 7, 2024
gouzil
changed the title
[SOT][3.13]add
[SOT][3.13] add Nov 7, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT][3.13] add LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
#69196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LOAD_FAST` and add skip tests files
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 6, 2024
| self.fused_load_store(instr) | ||
|
|
||
| def STORE_FAST_LOAD_FAST(self, instr: Instruction): | ||
| self.fused_load_store(instr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接在预处理字节码的时候拆一下吧
def expand_super_instrs(instructions: list[Instruction]) -> list[Instruction]:
expanded_instrs = []
def replace_jump_target(instrs, old_target, new_target):
for instr in instrs:
if instr.jump_to == old_target:
instr.jump_to = new_target
for instr in instructions:
if instr.opname == "LOAD_FAST_LOAD_FAST":
instr1 = Instruction(
opcode=dis.opmap["LOAD_FAST"],
opname="LOAD_FAST",
arg=instr.arg >> 4,
argval=instr.argval[0],
offset=instr.offset,
starts_line=instr.starts_line,
is_jump_target=instr.is_jump_target,
jump_to=instr.jump_to,
is_generated=True,
)
instr2 = Instruction(
opcode=dis.opmap["LOAD_FAST"],
opname="LOAD_FAST",
arg=instr.arg & 15,
argval=instr.argval[1],
offset=instr.offset,
starts_line=instr.starts_line,
is_jump_target=instr.is_jump_target,
jump_to=instr.jump_to,
is_generated=True,
)
replace_jump_target(instructions, instr, instr1)
expanded_instrs.append(instr1)
expanded_instrs.append(instr2)
else:
expanded_instrs.append(instr)
return expanded_instrs
SigureMo
changed the title
LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests filesLOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
SigureMo
reviewed
Nov 6, 2024
| @@ -91,6 +91,98 @@ def convert_instruction(instr: dis.Instruction) -> Instruction: | |||
| ) | |||
|
|
|||
|
|
|||
| def expand_super_instrs(instructions: list[Instruction]) -> list[Instruction]: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SigureMo
reviewed
Nov 6, 2024
| if instr.jump_to == old_target: | ||
| instr.jump_to = new_target | ||
|
|
||
| def _gen_instr(instr, opname, argval, arg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| def _gen_instr(instr, opname, argval, arg): | |
| def copy_instruction(instr, opname, argval, arg): |
Comment on lines
114
to
123
| if instr.opname == "LOAD_FAST_LOAD_FAST": | ||
| instr1 = _gen_instr( | ||
| instr, "LOAD_FAST", instr.argval[0], instr.arg >> 4 | ||
| ) | ||
| instr2 = _gen_instr( | ||
| instr, "LOAD_FAST", instr.argval[1], instr.arg & 15 | ||
| ) | ||
| replace_jump_target(instructions, instr, instr1) | ||
| expanded_instrs.append(instr1) | ||
| expanded_instrs.append(instr2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块不用写三次吧？写一个 map 就可以了
| arg=arg, | ||
| argval=argval, | ||
| is_jump_target=instr.is_jump_target, | ||
| is_generated=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| is_generated=True, | |
| is_generated=False, |
False 吧？
| opname=opname, | ||
| arg=arg, | ||
| argval=argval, | ||
| is_jump_target=instr.is_jump_target, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
第一个是 instr.is_jump_target，第二个是 False，不能直接 copy
SigureMo
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
gouzil
changed the title
LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests filesLOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
gouzil
changed the title
LOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests filesLOAD_FAST_LOAD_FAST、 STORE_FAST_STORE_FAST、 STORE_FAST_LOAD_FAST and add skip tests files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
LOAD_FAST_LOAD_FAST、STORE_FAST_STORE_FAST、STORE_FAST_LOAD_FAST三个字节码