CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:21:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=339.94281,conversation_content-fragment;desc="conversation_content fragment";dur=604.049427,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=309.367085,nginx;desc="NGINX";dur=0.844432,glb;desc="GLB";dur=101.84654
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RB5aGYAti5%2BBKGimudjtLUvoHAMBtaEq2DnHN70MJWZkPlX7w6SBJY9mgxUFOV8e4anTyrVnts8BCHPjH5wxyvCSzeY9jTdirWQ0DRaPFJJBbmbMtYtEJyafSqZ8%2B3rbHDASlMauRxMPYcF0qxUQ4x%2BqcljhQ9nKd73JT1fXe%2FYYpsycZJSDGbXs51ydZSly6C5dte84VWQF33dNQNHN8ru7bynSQMfIkSoZsUPCTDvaEzurukX%2BKz23feR%2FGNb11d3KSwFdbwT6qYurLsf4Pg%3D%3D--3%2FOJE5eHPjhlDOCu--Dtyp4w0ZttFlSi3Puf%2B04w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.68139157.1753330914; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:21:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:21:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DB28:18BEF9:309B72:439F45:6881B4E2
[Kernel&Prim] Fix `IndexPutCudaKernel` for thread safe and add index_put_double_grad by HydrogenSulfate · Pull Request #69095 · PaddlePaddle/Paddle · GitHub
[Kernel&Prim] Fix
[Kernel&Prim] Fix
HydrogenSulfate
requested review from
xiaoguoguo626807,
JiabinYang and
phlrain
as code owners
October 31, 2024 12:32
HydrogenSulfate
changed the title
[Prim] Add index_put_double_grad
[Kernel&Prim] Fix IndexPutCudaKernel for thread safe and add index_put_double_grad
Nov 1, 2024
HydrogenSulfate
changed the title
[Kernel&Prim] Fix IndexPutCudaKernel for thread safe and add index_put_double_grad
[Kernel&Prim] Fix Nov 1, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[Kernel&Prim] Fix IndexPutCudaKernel
for thread safe and add index_put_double_grad
#69095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HydrogenSulfate
merged 2 commits into
PaddlePaddle:develop
from
HydrogenSulfate:add_index_put_double_grad
Nov 4, 2024
Merged
[Kernel&Prim] Fix IndexPutCudaKernel
for thread safe and add index_put_double_grad
#69095
HydrogenSulfate
merged 2 commits into
PaddlePaddle:develop
from
HydrogenSulfate:add_index_put_double_grad
Nov 4, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
12 tasks
IndexPutCudaKernel
for thread safe and add index_put_double_grad
cubehan3
approved these changes
Nov 4, 2024
1 task
zyfncg
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
New features
Description
Pcard-75624
Related PR: deepmodeling/deepmd-kit#4157
IndexPutCudaKernel
线程不安全的+=
加法,改为phi::CudaAtomicAdd
,避免indices
中含有重复的坐标导致结果不正确index_put
添加到api.yaml
里作为基础算子,而后在index_put_double_grad
中复用该前向算子Note
由于gradient_checker不支持indices这一

Tuple[Tensor, ..]
输入类型,因此单测仅作覆盖率测试,精度测试与pytorch对比,如下所示(accumulate=False
时前向计算的结果为赋值操作,具有不确定性,因此该前向结果不进行对比)由于使用
CudaAtomicAdd
对性能可能有影响,测试结果如下(单位:毫秒,测试100次取后80次的平均值):可以看到
CudaAtomicAdd
会略微增加计算耗时,但是不会导致算子比pytorch更慢测试脚本如下
精度测试脚本如下: