| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 01:14:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=348.712919,conversation_content-fragment;desc="conversation_content fragment";dur=1043.974696,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=383.194525,nginx;desc="NGINX";dur=0.763524,glb;desc="GLB";dur=100.529476
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NZ323s1cfac8PrYfiwaXTY3ppV1DQ5%2Bhs0JvsKyngsg5FbMnFYSVugJ8Q%2BnEwjc%2FeRJCUwdvKNJZbrhJRILHk0QteXfowfbjYwAclBveA8SHvNvCy1Df4xu8a1ROECSOIGk1y0GJf7zRJftsvi6dUOeKyf1UvevmitRoDCZqXSKrs0sw21Xpe15o5ThKYzDNJ62kx7ftqXuY%2FI7Q6zjaSZpPcQyGpNUl%2B1aUsOqoTryRckwSxFOlHanDZ5bL2qBWLmdS%2FAc2CGU57zDGEzbgLw%3D%3D--0iP4xaHmHMXmH4YQ--qJ6JdyBVyXQNzMLq3XnR6w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.718975497.1753406065; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 01:14:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 01:14:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A1A4:B7ECB:6F780:AD95D:6882DA71
【Infer Symbolic Shape No.220】Add infer_symbol_shape for rnn by AndPuQing · Pull Request #68882 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Infer Symbolic Shape No.220】Add infer_symbol_shape for rnn #68882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/multiary_infer_sym.cc
Outdated
Show resolved
Hide resolved
test/legacy_test/op_test.py
Outdated
Comment on lines
2655
to
2657
| self.op_test._infer_and_compare_symbol( | ||
| place, no_check_set=no_check_set | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
符号推导会要求对所有的op result 都做推导，一般要求对所有 result 都做检查，添加no_check_set 可能会导致存量单测中某些result 的检查失效，例如ClassCenterSampleOp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里加no_check_set的目的是啥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为这里会check dropout_state 的shape，但是 dropout_state 输出shape 推导不出来，导致这个单测失败
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为这里会check
dropout_state的shape，但是dropout_state输出shape 推导不出来，导致这个单测失败
dropout_state 不同设备上的rank都是1，用新符号是没问题的，可以把符号推导的检查关掉；与PIR checker 的no_check_set 不适配问题等扩量任务结束之后我们再来处理
test/legacy_test/op_test.py
Outdated
Comment on lines
2655
to
2657
| self.op_test._infer_and_compare_symbol( | ||
| place, no_check_set=no_check_set | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里加no_check_set的目的是啥
Comment on lines
3323
to
3328
| int state_num = static_cast<int>(pre_state_shape_or_data_list.size()); | ||
| symbol::TensorListShapeOrDataDimExprs state_shape_or_data_list; | ||
| for (int i = 0; i < state_num; ++i) { | ||
| state_shape_or_data_list.emplace_back( | ||
| pre_state_shape_or_data_list[i].shape()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接使用size_t i吧
|
Sorry to inform you that c204436's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
luotao1
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
New features
Description
其中
dropout_state输出 Tensor 的 shape 是设备相关的。在GPU上，将会通过
Paddle/paddle/phi/kernels/gpu/rnn_functor.h
Line 148 in 8f67128
cudnnDropoutGetStatesSize() 得到
而在CPU kernel 中，将是
Paddle/paddle/phi/kernels/cpu/rnn_functor.h
Line 142 in 8f67128
该PR同时也为 symbolcheck 添加了no_check_set 支持