| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 02:27:11 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=248.246649,conversation_content-fragment;desc="conversation_content fragment";dur=811.52303,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=303.342066,nginx;desc="NGINX";dur=0.995524,glb;desc="GLB";dur=100.635499
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=FKUXUra98ya7j%2FY18Y%2BjQM6jQfsVlyR%2FTrtDHyYa2R39LVbe3V7vn0muqZxF7tO1D2itMiflinNcD6pLUQ%2BvoRW%2FR4ARDGDsoKFfeF4BGqJkXFd9vX5Hi4SjH%2FRLZkOixQIOu%2BUJ%2FiQlmX6BKUmxIfk63lDaNvF1r%2BSmqiVeNEPWv%2BqO5tc4bSik0k%2FvaGsuLMrO5VVOLIt8OpK8uf%2Bpl%2F5iFEMhVsfCtERV34Rc5bJseBAFBnKU05wmSv%2FujViqRhiV8vr%2BZyJQY0wxG1Rppw%3D%3D--iakbmJFr9GzylCIr--j2tMudaa5yMJ5XB%2B0065QQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1749411558.1753496830; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:27:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9106:15E61D:1025B:188F4:68843CFE
[AutoParallel] Add op_role_guard for PIR by JZ-LIANG · Pull Request #68796 · PaddlePaddle/Paddle · GitHub
JZ-LIANG
requested review from
XiaoguangHu01,
zhiqiu,
Xreki and
qili93
as code owners
October 18, 2024 04:18
JZ-LIANG
changed the title
[AutoParallel] Optimize Graph Optimization by revise vpp logic
[AutoParallel] Add op_role_guard for PIR
Oct 18, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[AutoParallel] Add op_role_guard for PIR #68796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JZ-LIANG
merged 12 commits into
PaddlePaddle:develop
from
JZ-LIANG:semi-auto/set_op_role
Oct 22, 2024
Merged
[AutoParallel] Add op_role_guard for PIR #68796
JZ-LIANG
merged 12 commits into
PaddlePaddle:develop
from
JZ-LIANG:semi-auto/set_op_role
Oct 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JZ-LIANG
requested review from
XiaoguangHu01,
zhiqiu,
Xreki and
qili93
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
JZ-LIANG
changed the title
winter-wang
reviewed
Oct 18, 2024
paddle/pir/include/core/builder.h
Outdated
|
|
||
| // by now the op_role is used by autoparallel for distinguish the op in fw, | ||
| // bw, opt region. | ||
| int current_op_role_ = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| int current_op_role_ = -1; | |
| int op_role_ = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
paddle/pir/include/core/builder.h
Outdated
| @@ -115,7 +115,9 @@ class Builder { | |||
| common::errors::PreconditionNotMet("argument of block is nullptr")); | |||
| set_insertion_point(block, block->end()); | |||
| } | |||
|
|
|||
| /// Set/Get the op_role | |||
| void SetCurrentOpRole(int op_role) { current_op_role_ = op_role; } | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| void SetCurrentOpRole(int op_role) { current_op_role_ = op_role; } | |
| void set_op_role(int op_role) { op_role_ = op_role; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
paddle/pir/include/core/builder.h
Outdated
|
|
||
| /// Set/Get the op_role | ||
| void SetCurrentOpRole(int op_role) { current_op_role_ = op_role; } | ||
| int GetCurrentOpRole() const { return current_op_role_; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| int GetCurrentOpRole() const { return current_op_role_; } | |
| int op_role() const { return op_role_; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
winter-wang
previously approved these changes
Oct 18, 2024
winter-wang
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Auto Parallel
PR Types
Improvements
Description
Add op_role_guard for PIR to Optimize Graph compilation for Pipeline logic
Reduce the DAG Rewrite Compilation time in pir parallel
Pcard-67164