| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:05:51 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=220.67499,conversation_content-fragment;desc="conversation_content fragment";dur=1090.363321,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=262.366882,nginx;desc="NGINX";dur=0.538004,glb;desc="GLB";dur=100.633055
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=VMUmK16wZGQkIqsyb9oHwotVOfcryhtz4vlRb3tMeKtfixQ%2F1XvaAKIREvs9qSh4GDAHl3ac84szc8vtRNYYSYHTwdi7JqX8iFzcEt9zIw890pngCCpsjahoyXA5YrIzptZuedg4NV6h4k2BbqOyrH3mGUPTEFUF30lJ3PiPBV6FXozdSf4I5Ux1rJw4g7nXhcPsv%2FesLpUT%2BN%2FPVtAz7jXwATKMWtUSF%2FT4W1F%2BWk%2BMZDzmhR%2FMifNgDkV0%2BqoTnbAkJSHNhbARzU4JPOFiFQ%3D%3D--j3RCzn7jlHg3T8tz--586u2QpCTzWinWpFVQIh1Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1687116411.1753401949; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:05:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:05:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C5FA:23280:2E4E2:493D3:6882CA5D
[ Auto Parallel ]replace softmax_with_cross_entropy with c_softmax_with_cross_entropypass by waliwali777 · Pull Request #68182 · PaddlePaddle/Paddle · GitHub
waliwali777
requested review from
LiYuRio,
ForFishes and
zhiqiu
as code owners
September 12, 2024 08:57
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
September 12, 2024 09:13
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
2 times, most recently
from
September 25, 2024 10:46
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
October 8, 2024 02:15
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
October 8, 2024 03:31
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
2 times, most recently
from
October 8, 2024 10:17
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
3 times, most recently
from
October 10, 2024 08:40
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
October 10, 2024 12:07
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
October 12, 2024 05:33
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[ Auto Parallel ]replace softmax_with_cross_entropy with c_softmax_with_cross_entropypass #68182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
liym27
merged 2 commits into
PaddlePaddle:develop
from
waliwali777:softmax_with_cross_entropy_pass
Oct 14, 2024
Merged
[ Auto Parallel ]replace softmax_with_cross_entropy with c_softmax_with_cross_entropypass #68182
liym27
merged 2 commits into
PaddlePaddle:develop
from
waliwali777:softmax_with_cross_entropy_pass
Oct 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waliwali777
requested review from
LiYuRio,
ForFishes and
zhiqiu
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
e6e5741 to
636c46a
Compare
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
2 times, most recently
from
d4d774f to
c18990c
Compare
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
d1c9616 to
c572acb
Compare
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
c572acb to
ff62f94
Compare
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
2 times, most recently
from
70cd4dd to
7c08d92
Compare
liym27
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a todo: add llama testing with this pass
| @@ -340,7 +340,7 @@ class _DPOptimizationConfig(TypedDict, total=False): # noqa: PYI049 | |||
| set_field_default_config( | |||
| MP_OPTIMIZATION, "allreduce_matmul_grad_overlapping", False | |||
| ) | |||
|
|
|||
| set_field_default_config(MP_OPTIMIZATION, "replace_with_c_softmax", False) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace_with_c_softmax -> replace_with_parallel_cross_entropy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| super().__init__() | ||
| self._in_pir_mode = paddle.base.framework.get_flags( | ||
| "FLAGS_enable_pir_api" | ||
| )["FLAGS_enable_pir_api"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._in_pir_mode is not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
python/paddle/distributed/passes/auto_parallel_replace_with_parallel_cross_entropy.py
Show resolved
Hide resolved
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
3 times, most recently
from
627d818 to
c741a52
Compare
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
c741a52 to
23fa385
Compare
waliwali777
force-pushed
the
softmax_with_cross_entropy_pass
branch
from
706a82e to
c0a9eeb
Compare
XieYunshen
approved these changes
Oct 12, 2024
liym27
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Auto Parallel
PR Types
Performance
Description
基于PIR实现静半
parallel_cross_entroy通信算子的标记优化，在 mp 列切 + hard label 的情况下，将softmax_with_cross_entropy算子替换使用通信效率更高的c_softmax_with_cross_entropypass算子perf in llama-7B dp1mp2pp1 with using pass
close pass: 323.2 token/card/s
open pass: 329.0 token/card/s
Pcard-70448