| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[DCU] Add hipblaslt support #68066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCU] Add hipblaslt support #68066
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
There is two flags in |
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | ||
| Copyright (c) 2022 NVIDIA Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License这里是对的吗？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License后面单独提一个PR修复叭，CI比较耗时，会推迟合入时间～
| @@ -0,0 +1,1257 @@ | |||
| /* Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023 -> 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
|
|
||
| #ifdef PADDLE_WITH_HIP | ||
|
|
||
| #include "glog/logging.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
头文件中不建议使用glog等三方库头文件，可以放到.cc中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里确实有LOG的需求，并且和blaslt_impl.cu.h是对齐的～
| /* Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License格式有点问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
blaslt有开关吗 |
当时主要目的是添加hipblaslt后端的支持，算子方面本PR仅支持了fused_gemm_epilogue，此前该算子由matmul和add两个算子组合实现。若要对比blaslt添加前后的效果，可以参考PR描述中的两个Case。 您说的开关，没有参数或者环境变量来控制是否开启hipblaslt，对于本PR来讲，不调用fused_gemm_epilogue算子就不会调用到hipblaslt。 |
PR Category
Custom Device
PR Types
New features
Description
card-86662
Add hipblaslt support for DCU.
Operator performance comparison: