【CINN】Add IterMark/IterSplit/IterSum structures and conversion methods #68011

liuruyan · 2024-09-04T13:57:38Z

PR Category

CINN

PR Types

New features

Description

Add IterExpr: IterMark/IterSplit/IterSum basic structures, IterMark is a mark for entirely iter.

IterSplit = source / lower_factor % extent * scale
IterSum = Sum(args) + base

Add conversion method for Expr and IterExpr.
Add Visit func for simplify: Add, Sub, Mul.
Extract the const_fold function into a separate file.

Pcard-67164

… iter_bind_0

zyfncg · 2024-09-05T12:54:44Z

paddle/cinn/common/const_fold.h

@@ -0,0 +1,75 @@
+// Copyright (c) 2023 CINN Authors. All Rights Reserved.


2023 -> 2024

zyfncg · 2024-09-05T13:02:16Z

paddle/cinn/common/const_fold.h

+  }
+  return std::nullopt;
+}
+


为什么没有除法？

会在下一个pr中引入除法，因为当前pr没有visit(Div)

zyfncg · 2024-09-05T13:02:45Z

paddle/cinn/common/iter_simplify.cc

@@ -0,0 +1,275 @@
+// Copyright (c) 2023 CINN Authors. All Rights Reserved.


2023 -> 2024

zyfncg · 2024-09-05T13:04:20Z

paddle/cinn/common/iter_simplify.cc

+namespace cinn {
+namespace common {
+
+bool isIterExpr(const Expr& a, const Expr& b) {


首字母大写

zyfncg · 2024-09-05T13:04:32Z

paddle/cinn/common/iter_simplify.cc

+         b.As<ir::IterSplit>() || b.As<ir::IterSum>();
+}
+
+bool isOne(const Expr& expr) {


zyfncg · 2024-09-06T02:17:48Z

paddle/cinn/ir/ir.h

+  Type type() const { return source.type(); }
+  Expr source;
+  Expr lower_factor;
+  Expr extent;
+  Expr scale;


这些成员变量的含义需要加注释说明下

zyfncg · 2024-09-06T02:17:56Z

paddle/cinn/ir/ir.h

+  std::vector<Expr> args;
+  Expr base;


zyfncg · 2024-09-06T02:18:48Z

paddle/cinn/common/iter_simplify_test.cc

测试文件加到test目录下

zyfncg · 2024-09-06T02:18:58Z

paddle/cinn/common/iter_simplify_test.cc

@@ -0,0 +1,219 @@
+// Copyright (c) 2023 CINN Authors. All Rights Reserved.


2023 -> 2024

zyfncg · 2024-09-06T02:20:04Z

paddle/cinn/common/iter_simplify.h

@@ -0,0 +1,78 @@
+// Copyright (c) 2023 CINN Authors. All Rights Reserved.


2023 -> 2024

… iter_bind_0

Aurelius84

LGTM for const_cast

Aurelius84 · 2024-09-09T10:47:10Z

paddle/cinn/common/iter_simplify.h

+
+class IterMapToExprNormalizer : public ir::IRMutator<> {
+ public:
+  explicit IterMapToExprNormalizer(SymbolicExprAnalyzer analyzer)


Suggested change

explicit IterMapToExprNormalizer(SymbolicExprAnalyzer analyzer)

explicit IterMapToExprNormalizer(const SymbolicExprAnalyzer& analyzer)

这里是值copy传入，然后引用这个copy？

liuruyan added 2 commits September 4, 2024 13:23

Iterbind structure.

15d4675

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

18c774c

… iter_bind_0

zyfncg reviewed Sep 6, 2024

View reviewed changes

liuruyan added 3 commits September 8, 2024 15:55

fix comment

2fb5676

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

da1608d

… iter_bind_0

fix comment.

1a2f70f

Aurelius84 approved these changes Sep 9, 2024

View reviewed changes

zyfncg approved these changes Sep 9, 2024

View reviewed changes

zyfncg merged commit b94916c into PaddlePaddle:develop Sep 10, 2024
28 of 29 checks passed

liuruyan changed the title ~~Add IterMark/IterSplit/IterSum structures and conversion methods~~ 【CINN】Add IterMark/IterSplit/IterSum structures and conversion methods Oct 16, 2024

		@@ -0,0 +1,75 @@
		// Copyright (c) 2023 CINN Authors. All Rights Reserved.

		@@ -0,0 +1,275 @@
		// Copyright (c) 2023 CINN Authors. All Rights Reserved.

		@@ -0,0 +1,219 @@
		// Copyright (c) 2023 CINN Authors. All Rights Reserved.

		@@ -0,0 +1,78 @@
		// Copyright (c) 2023 CINN Authors. All Rights Reserved.

	explicit IterMapToExprNormalizer(SymbolicExprAnalyzer analyzer)
	explicit IterMapToExprNormalizer(const SymbolicExprAnalyzer& analyzer)

【CINN】Add IterMark/IterSplit/IterSum structures and conversion methods #68011

【CINN】Add IterMark/IterSplit/IterSum structures and conversion methods #68011

Uh oh!

Conversation

liuruyan commented Sep 4, 2024

PR Category

PR Types

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aurelius84 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!