| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:05:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=235.397768,conversation_content-fragment;desc="conversation_content fragment";dur=807.475402,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=293.887115,nginx;desc="NGINX";dur=0.969772,glb;desc="GLB";dur=100.616882
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YZTywaSSjRoGR3qRieI2nf31q%2FIGHSTASMFFtDn%2F3AUt8R3wNYthQC0tXovvXD7TxgfXdS7mQEGQzO3p3UZk%2BtAXLZN%2BOXpYlCegjUVPQkrrbdPXZLADexa7o8GFsNNJTL%2FJJJe3ZHaZMdv2Ouwk2ULRpqoFVXW0eHJreX%2Ba6WFZbEHC9VeyR%2B%2FxTiIx6VdPxvf%2BiVhLEt8w4CGzC6Z0dIHbnmVfV5Nmj2y3JUZLMOmgI5GhFSmjiTx%2BS3%2BzK6JOSK7FZs6eIwov0tn0K1KWbw%3D%3D--6GrlZEiwtmY7tOdC--FB6pyd9NIpgMmUSz87lO1Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.647189670.1753401941; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:05:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:05:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9190:C8A1:2E2EE:491D7:6882CA55
[PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined by SigureMo · Pull Request #67981 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[Dy2St] Set TensorArray dtype after first write if its type is undefined
[PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined
Sep 13, 2024
SigureMo
dismissed stale reviews from changeyoung98 and winter-wang
via
September 14, 2024 03:20
SigureMo
changed the title
[PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined
[Typing][PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined
Sep 14, 2024
SigureMo
changed the title
[Typing][PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined
[PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined
Sep 14, 2024
SigureMo
deleted the
dy2st/set-tensor-array-dtype-after-first-write-if-its-type-is-undefined
branch
September 16, 2024 05:22
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined #67981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
cattidea:dy2st/set-tensor-array-dtype-after-first-write-if-its-type-is-undefined
Sep 16, 2024
Merged
[PIR][Dy2St] Set TensorArray dtype after first write if its type is undefined #67981
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
cattidea:dy2st/set-tensor-array-dtype-after-first-write-if-its-type-is-undefined
Sep 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
…write-if-its-type-is-undefined
SigureMo
changed the title
winter-wang
reviewed
Sep 14, 2024
paddle/pir/include/core/builder.h
Outdated
| @@ -136,6 +137,7 @@ class Builder { | |||
| template <typename OpTy, typename... Args> | |||
| OpTy Build(Args &&...args); | |||
|
|
|||
| IR_API UndefinedDataType undefined_data_type(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是不是可以直接叫UndefinedType, 赶紧"Data"有点冗余，个人觉得在不存在歧义的情况下，名字越短越好。
winter-wang
previously approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
changeyoung98
previously approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SigureMo
dismissed stale reviews from changeyoung98 and winter-wang
via
13f5d88
zhangbo9674
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winter-wang
approved these changes
Sep 14, 2024
changeyoung98
approved these changes
Sep 14, 2024
SigureMo
changed the title
SigureMo
changed the title
SigureMo
deleted the
dy2st/set-tensor-array-dtype-after-first-write-if-its-type-is-undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
对于上述情况，动转静下会对
l创建一个 float32 的TensorArray，但后续会往里面添加 int64 的数据，这里我们有两种可以处理的方式：之前是直接报错的，后来加上了 cast，这两种其实都有问题，前者会导致大量存量代码需要修改，后者会导致后续取出的元素永远是 float32
由于这里原来是动态图代码，用户没有显式标注类型，因此从最开始而言其类型就应该是
Array<Unknown>，在发现后续有append(i64)时应该自动推导为Array<i64>，这是符合编译器的类型推导原则的从 Paddle 的框架或者说 PIR 的角度，使用了
UndefinedDataType来表示最开始尚未确定类型，对应 phi 下的DataType::UNDEFINED，我们会为动转静转换的元素 dtype 设置为 undefined，而在后面append时候触发的ArrayWriteInferMeta设置成第一个元素的 dtype由于动转静只有捕获
append等相关操作才会转为 TensorArray，因此创建的UndefinedDataType的 array 一定会在组网期间确定类型，组网完成后不会再有UndefinedDataType的 TensorArrayPcard-67164