| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 23:47:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=264.406985,conversation_content-fragment;desc="conversation_content fragment";dur=895.371414,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=283.725209,nginx;desc="NGINX";dur=0.833516,glb;desc="GLB";dur=100.623584
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=29iZPyB9eF9peNpApSY0oKZegN8tCQjBbzGsLPt7VWeC0R6GsTzu%2BRFtRFXnAbU1A2me6%2FapY9BTwLSCoY2AdhrGEZC8QdsyH5LNyUFrIKVgJwasIkJREoGcvBHMwc5yBLPCIrBuAMJEnfnPWtoLNdfzMMRPOdTs%2Be98s2jm4yxwIa29TZSCIp0BU957icGIsN0iti6gOEn58IKHE8amHLvjGIbtK2emyjvWopnSAloQMO68xwuwYxvYeULHwb0eoNpMDwUfR3UNScvcZJrvWw%3D%3D--Kq6uq1g2VKQe8CBn--%2BQdRHuQZwCJ5kNZ6AIx83A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1706997282.1753400826; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:47:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 23:47:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9EF8:32222C:1E648:2FCB1:6882C5FA
【BUAA】【Infer Symbolic Shape】添加 weight_only_linear op的符号推导接口 by Jeff114514 · Pull Request #67875 · PaddlePaddle/Paddle · GitHub
Jeff114514
changed the title
【BUAA】【Infer Symbolic Shape】Add Weight only linear for CINN
【BUAA】【Infer Symbolic Shape】添加 weight_only_linear op的符号推导接口
Sep 4, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【BUAA】【Infer Symbolic Shape】添加 weight_only_linear op的符号推导接口 #67875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
标题修改一下，添加 weight_only_linear op的符号推导接口 |
gongshaotian
reviewed
Sep 4, 2024
| auto weight_scale_shape = weight_scale_shape_or_data.shape(); | ||
| auto x_shape = x_shape_or_data.shape(); | ||
| auto weight_shape = weight_shape_or_data.shape(); | ||
| auto n = group_size == -1 ? weight_scale_shape[0] : weight_scale_shape[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接写明类型，尽量不使用auto
| // 0, | ||
| // common::errors::InvalidArgument( | ||
| // "The second dimension of input must be divisible by 16, but | ||
| // got[%d]", weight_shape[1])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把这两个Enforce的注释删了，修改成TODO项
| "Input(X) dim[-1] and Input(Weight) dim[1] should be equal." | ||
| "But received Input(X) dim[-1](%s) != Input(Weight) dim[1](%s)", | ||
| x_shape[x_shape.size() - 1], | ||
| weight_shape[1])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该使用equalcstr
| x_shape[x_shape.size() - 1], | ||
| weight_shape[1])); | ||
| if (!bias_shape_or_data.isa<symbol::NullShapeOrDataDimExpr>()) { | ||
| auto bias_shape = bias_shape_or_data.shape(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto同上
| "The input(weight_scale) must be a 2D Tensor" | ||
| " in groupwise mode.")); | ||
| PADDLE_ENFORCE_EQ(weight_scale_shape[0], | ||
| (weight_shape[1] + (group_size - 1)) / group_size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上DIm的约束应该使用equalcstr
Jeff114514
changed the title
Jeff114514
commented
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已完成修改
gongshaotian
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved，const &的问题可以放后面的PR修改
|
|
||
| ExprVec weight_scale_shape = weight_scale_shape_or_data.shape(); | ||
| ExprVec x_shape = x_shape_or_data.shape(); | ||
| ExprVec weight_shape = weight_shape_or_data.shape(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能用 const & 尽量用，避免copy
luotao1
approved these changes
Sep 6, 2024
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Others
Description
增加了新的符号推导
测试位于test_weight_only_linear.py 缺失optest
约束信息暂未修改，沿用了infermeta的PADDLE_ENFORCE